Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:28671 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82414 invoked by uid 1010); 4 Apr 2007 08:07:35 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 82399 invoked from network); 4 Apr 2007 08:07:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Apr 2007 08:07:35 -0000 Authentication-Results: pb1.pair.com smtp.mail=antony@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=antony@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: antony@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:48591] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 52/C3-18035-4CC53164 for ; Wed, 04 Apr 2007 04:07:35 -0400 Received: (qmail 5998 invoked from network); 4 Apr 2007 08:07:29 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 4 Apr 2007 08:07:29 -0000 Message-ID: <46135CC0.7030108@zend.com> Date: Wed, 04 Apr 2007 12:07:28 +0400 User-Agent: Thunderbird 2.0b2 (X11/20070116) MIME-Version: 1.0 To: js CC: internals@lists.php.net References: <46129ECC.4010402@zend.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Unexpected usage of 'duplicate' flag in sapi_add_header_ex() From: antony@zend.com (Antony Dovgal) On 04/04/2007 03:18 AM, js wrote: > Hi Antony. > > Thanks you for replying. > >> > If so, any reason to break the coding standard in this instance? >> >> Standards are general rules, there might be some exceptions. >> (It doesn't mean I personally like this code or encourage to ignore the standards). >> >> > and what does, in this context, 'duplicate' means? >> >> See main/main.c, line 1119 for example. >> It might be convenient to free duplicated buffer and ignore static one. > > Then wouldn't it be nice call that flag static or no_duplicate or something? > I thought 'duplicate' is misleading name. Don't fix something that isn't broken. There are a lot of places requiring attention, this is not one of them. -- Wbr, Antony Dovgal