Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:28670 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56980 invoked by uid 1010); 3 Apr 2007 23:18:59 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 56965 invoked from network); 3 Apr 2007 23:18:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Apr 2007 23:18:59 -0000 Authentication-Results: pb1.pair.com header.from=ebgssth@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=ebgssth@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.175 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: ebgssth@gmail.com X-Host-Fingerprint: 66.249.92.175 ug-out-1314.google.com Linux 2.4/2.6 Received: from [66.249.92.175] ([66.249.92.175:47454] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 67/B7-18035-FD0E2164 for ; Tue, 03 Apr 2007 19:18:58 -0400 Received: by ug-out-1314.google.com with SMTP id o4so485492uge for ; Tue, 03 Apr 2007 16:18:52 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Z2baKe02MLvIZSipnlYYXx4+mYQf/s+lRh0te215BYQn1WHdPbI2FI3wbrPIRIbcYI3wc6NgF3p590lAlz/Y00ciNibm8uMrMCr9CyxxYt9ihCEqm/gUCbNRJoJ4KzLhcdX7PNtE1e02ftd8Zx7q+IAU0n69n3rKpzPrJg+zuPk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=J+pCLrEAtBUVeWu/MBl2lMjRgejIGfpf8hyBQAdxsRY68V4BEvrI4E+4As9TMbvqSq0nZzRi9Xuq8HycODUeLndz3LKCBU1uIaHHYFuV/QOarwpRr7CZ63xwUnvX+ONPAmcsZBSoNqGZzgh1cchZl7tebe9KBukhspO/kDZpmFs= Received: by 10.66.242.20 with SMTP id p20mr980149ugh.1175642332211; Tue, 03 Apr 2007 16:18:52 -0700 (PDT) Received: by 10.66.216.17 with HTTP; Tue, 3 Apr 2007 16:18:52 -0700 (PDT) Message-ID: Date: Wed, 4 Apr 2007 08:18:52 +0900 To: "Antony Dovgal" Cc: internals@lists.php.net In-Reply-To: <46129ECC.4010402@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <46129ECC.4010402@zend.com> Subject: Re: [PHP-DEV] Unexpected usage of 'duplicate' flag in sapi_add_header_ex() From: ebgssth@gmail.com ("js ") Hi Antony. Thanks you for replying. > > If so, any reason to break the coding standard in this instance? > > Standards are general rules, there might be some exceptions. > (It doesn't mean I personally like this code or encourage to ignore the standards). > > > and what does, in this context, 'duplicate' means? > > See main/main.c, line 1119 for example. > It might be convenient to free duplicated buffer and ignore static one. Then wouldn't it be nice call that flag static or no_duplicate or something? I thought 'duplicate' is misleading name.