Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28647
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 66.249.92.172 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=beta;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=W+A2vG98WH6CUOYi69EsavRuyW+jVa3NJM2Iq3gJ8JHpWYkVMLvMYO+etb1qBjeJVsibMfPg/ApV7ivvf7+b7Qnoedo3HcN4pneEEgWg10kAWVK0cVefeqzkNzrcXVn4hJReltfnBdz/ayWJxoqXac9dLGtzp2hrUlTGkWCBK/I=
Message-ID: <10845a340704020206o74309016xd4c75f8efa5581b8@mail.gmail.com>
Date: Mon, 2 Apr 2007 10:06:38 +0100
Reply-To: RQuadling@GoogleMail.com
To: internals <internals@lists.php.net>
In-Reply-To: <10845a340704020057j7e6d6259g7d7918ad3da40731@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <10845a340703220843w4676feddid2de20af2fda3d22@mail.gmail.com>
	 <10845a340704020057j7e6d6259g7d7918ad3da40731@mail.gmail.com>
Subject: Re: Patches for bug#33664
From: rquadling@googlemail.com ("Richard Quadling")

On 02/04/07, Richard Quadling <rquadling@googlemail.com> wrote:
> On 22/03/07, Richard Quadling <rquadling@googlemail.com> wrote:
> > As subject.
> >
> Does anyone care about this? For those on Windows, the black box is
> REALLY annoying when you develop scheduled CLI scripts which call
> external apps. It takes focus away from what ever you are doing and
> there is no need for the window.
>
> I'm not saying that the shell shouldn't be launched, that is a
> separate issue, just that the console window shouldn't/needn't be
> shown.
>
> Regards,
>
> Richard Quadling.
>
>
> --
> -----
> Richard Quadling
> Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
> "Standing on the shoulders of some very clever giants!"
>
Just in case you can't see the patches ...

Index: tsrm_win32.c
===================================================================
RCS file: /repository/TSRM/tsrm_win32.c,v
retrieving revision 1.31
diff -u -r1.31 tsrm_win32.c
--- tsrm_win32.c	20 Mar 2007 17:57:44 -0000	1.31
+++ tsrm_win32.c	22 Mar 2007 15:39:50 -0000
@@ -219,7 +219,7 @@

 	cmd = (char*)malloc(strlen(command)+strlen(TWG(comspec))+sizeof(" /c "));
 	sprintf(cmd, "%s /c %s", TWG(comspec), command);
-	if (!CreateProcess(NULL, cmd, &security, &security,
security.bInheritHandle, NORMAL_PRIORITY_CLASS, env, cwd, &startup,
&process)) {
+	if (!CreateProcess(NULL, cmd, &security, &security,
security.bInheritHandle, NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW,
env, cwd, &startup, &process)) {
 		return NULL;
 	}
 	free(cmd);

Index: proc_open.c
===================================================================
RCS file: /repository/php-src/ext/standard/proc_open.c,v
retrieving revision 1.54
diff -u -r1.54 proc_open.c
--- proc_open.c	24 Feb 2007 16:25:55 -0000	1.54
+++ proc_open.c	22 Mar 2007 15:39:17 -0000
@@ -738,11 +738,11 @@
 	}
 	
 	if (bypass_shell) {
-		newprocok = CreateProcess(NULL, command, &security, &security,
TRUE, NORMAL_PRIORITY_CLASS, env.envp, cwd, &si, &pi);
+		newprocok = CreateProcess(NULL, command, &security, &security,
TRUE, NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW, env.envp, cwd, &si,
&pi);
 	} else {
 		spprintf(&command_with_cmd, 0, "%s /c %s", GetVersion() <
0x80000000 ? COMSPEC_NT : COMSPEC_9X, command);

-		newprocok = CreateProcess(NULL, command_with_cmd, &security,
&security, TRUE, NORMAL_PRIORITY_CLASS, env.envp, cwd, &si, &pi);
+		newprocok = CreateProcess(NULL, command_with_cmd, &security,
&security, TRUE, NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW, env.envp,
cwd, &si, &pi);

 		efree(command_with_cmd);
 	}

http://rquadling.php1h.com/proc_open.diff.txt
and
http://rquadling.php1h.com/tsrm_win32.diff.txt



-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"