Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28375
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.132.251 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=beta;
        h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding;
        b=lMObINGO7RstyFWwCLcPq60W2662Dr1bcqojnncUHpAp1/sOsKqQluH604fsQKUld50ZDn5I7ifhpCxEHlcqLbNgqPQgur91RNvicU5s14XTOxfosKK6MDmSFosyKrEtv2JtXvGD96Gsrt/5eROvCs0+/Ceuzpz5+6YOwHcXRZc=
Message-ID: <45FB129C.5030907@googlemail.com>
Date: Fri, 16 Mar 2007 21:56:44 +0000
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: Marcus Boerger <helly@php.net>,  internals@lists.php.net
References: <45F8173F.3010902@googlemail.com> <622207866.20070314203432@marcus-boerger.de> <45FAA90C.7070006@googlemail.com> <755864469.20070316183914@marcus-boerger.de>
In-Reply-To: <755864469.20070316183914@marcus-boerger.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] php.ini and PHPT
From: zoe.slattery@googlemail.com (Zoe Slattery)

Hi Marcus

Marcus Boerger wrote:
> Then I saw you changed a hell lot of expectations from "(-%d)" to "(%i)".
> While this pretty much works it drops an important detail of the expectation.
> The old version was aware of the sign of the result while the new one is not.
> That means that now you might fix a bug in those functions that lead to an
> erroneous change in the sign and not being able to detect that. Though a lot
> os code is relying on the sign (e.g. any sorting algorithm).
>   
Eek - then I misunderstood what %i does, as you saw,  I had originally 
used %d - it's easy enough to change back :-)
> Do b) and be as precise as possible. That means we usually even test for the
> name of the testfile in the message excluding the directory and any
> (back)slash.
>   

Will do - thanks for the feedback, it's really helpful
>