Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28280
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.184.239 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=od1kKP5i7MlvzltV/17sPm8BHOrhOpDGDIaak6BGgj1WcuCCYaN9CWFT5Zx7eAThdcpeVmchwBQRMz5WgM4Z/isnhCO3kjip4OHC6Asrxe+5PEtOdg7xdsPW6rnjeSvXP0/TX5VmM7V1NDWSS0y9uWsxSmZL7lY0JJJbMFy8eR4=
Message-ID: <4e89b4260703062209r6197b580qd77958a3dc9004eb@mail.gmail.com>
Date: Wed, 7 Mar 2007 01:09:06 -0500
To: "Michael Vergoz" <mv@binarysec.com>
Cc: ceo@l-i-e.com, internals@lists.php.net
In-Reply-To: <00ac01c75f2c$44efe280$070110ac@michaelb651094>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <008c01c75c05$b6584ae0$070110ac@michaelb651094>
	 <41168.216.230.84.67.1172786770.squirrel@www.l-i-e.com>
	 <00ac01c75f2c$44efe280$070110ac@michaelb651094>
Subject: Re: [PHP-DEV] Thread safe problem on module_registry (Zend API Feature/Change request)
From: kingwez@gmail.com ("Wez Furlong")

Just curious, why did you choose to mutex around a hash instead of
using the zend_ts_hash functions?

Changing the access semantics while preserving the type and name of
that variable will cause any external modules that are unaware of that
change to subtly break, or if you're lucky, crash hard.

Seems "better" to make that break a little bit more obvious by
changing the name, or introducing an API to encapsulate the correct
access semantics.

These are just suggestions.  My main comments are that the locking
macros are mildly ugly and that a lack of compile time enforcement on
the new locking requirement will cause people pain with modules
outside of the main php distribution.

--Wez.



On 3/5/07, Michael Vergoz <mv@binarysec.com> wrote:
> Hello,
>
> I made a patch that "mutex'ed" module_registry and module_count.
> For the moment it doesn't solve the dl().
>
> The patch for last CVS PHP_5_2
> http://mykii.binarysec.com/PHP/module_registry_mutex/module_register_mutex.patch
>
> Small description :
> http://mykii.binarysec.com/PHP/module_registry_mutex/readme.txt
>
> Regards,
> Michael Vergoz
>
> ----- Original Message -----
> From: "Richard Lynch" <ceo@l-i-e.com>
> To: "Michael Vergoz" <mv@binarysec.com>
> Cc: <internals@lists.php.net>
> Sent: Thursday, March 01, 2007 11:06 PM
> Subject: Re: [PHP-DEV] Thread safe problem on module_registry (Zend API
> Feature/Change request)
>
>
> > On Thu, March 1, 2007 7:29 am, Michael Vergoz wrote:
> >
> > I don't claim to understand this issue fully/deeply, but I'm
> > definitely +1 on resurrecting 'dl' if this change fixes everything to
> > everyone's satisfaction.
> >
> > Not that my vote actually counts, as I've never had the skills/time to
> > actually contribute C code to PHP.
> >
> > I may be the only user on the planet with a shared host that lets me
> > use 'dl' to pull in extensions, but there it is, and I kinda need it,
> > as there are no other viable options to do what I need to do, other
> > than changing to a new webhost I might not like... :-)
> >
> > --
> > Some people have a "gift" link here.
> > Know what I want?
> > I want you to buy a CD from some starving artist.
> > http://cdbaby.com/browse/from/lynch
> > Yeah, I get a buck. So?
> >
> >
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>