Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28172
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 85.214.94.56 cause and error)
Date: Tue, 27 Feb 2007 21:55:55 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <479740775.20070227215555@marcus-boerger.de>
To: Sebastian Bergmann <sb@sebastian-bergmann.de>
CC: internals@lists.php.net
In-Reply-To: <es1nmo$fh$1@sea.gmane.org>
References: <es10qs$8f4$1@sea.gmane.org> <es1nmo$fh$1@sea.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV]  Benchmark Suite
From: helly@php.net (Marcus Boerger)

Hello Sebastian,

  looks pretty fine. Only you don't need fallbacks right now. Simply add a
check for PHP >= 5.2.0 since you are using Iterators and I don't see any
sense in testing 5.0 or 5.1. You could further more make the run script
operate a bit like run-tests.php and have the PHP executable be
configurable and get version tested. So you would first check that the PHP
runiing the run script is new enough and that second the tests are executed
by an acceptable PHP version.

When you want to spend more work, ever thought of making the bench files
have a layout similar to *.phpt? So that we could split up in sections like
name, actual bench, clean-up, etc? Or do you prefer to do all from within
one file and call bench funcs manually?

best regards
marcus

Tuesday, February 27, 2007, 5:53:53 PM, you wrote:

> Sebastian Bergmann wrote:
>> Have a look at

>  I uploaded a snapshot of what I have now (I added fallbacks for missing
>  functionality in PHP 4.4 and PHP 5.0 and the rest of the benchmarks) to
>  http://static.phpunit.de/benchmark.tbz2.

> -- 
> Sebastian Bergmann                          http://sebastian-bergmann.de/
> GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69




Best regards,
 Marcus