Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:28107 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87412 invoked by uid 1010); 21 Feb 2007 08:08:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 87395 invoked from network); 21 Feb 2007 08:08:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Feb 2007 08:08:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=php_lists@realplain.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=php_lists@realplain.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain realplain.com from 69.179.208.43 cause and error) X-PHP-List-Original-Sender: php_lists@realplain.com X-Host-Fingerprint: 69.179.208.43 msa3-mx.centurytel.net Linux 2.4/2.6 Received: from [69.179.208.43] ([69.179.208.43:43836] helo=msa3-mx.centurytel.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B3/D2-56941-01EFBD54 for ; Wed, 21 Feb 2007 03:08:49 -0500 Received: from pc1 (72-161-61-133.dyn.centurytel.net [72.161.61.133]) by msa3-mx.centurytel.net (8.13.6/8.13.6) with SMTP id l1L88iZA025554; Wed, 21 Feb 2007 02:08:44 -0600 Message-ID: <010a01c7558f$8206da80$0201a8c0@pc1> To: "Derick Rethans" , "PHP Developers Mailing List" References: Date: Wed, 21 Feb 2007 02:08:44 -0600 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0107_01C7555D.37143860" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1807 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1896 Subject: Re: [PHP-DEV] 4.4.6RC1 From: php_lists@realplain.com ("Matt Wilmas") ------=_NextPart_000_0107_01C7555D.37143860 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Hi Derick, Attached is a very simple patch for Bug #40115 (possibly wrong numeric string comparison caused by overflow) if you want to fix it in 4.4. :-) Matt ----- Original Message ----- From: "Derick Rethans" Sent: Tuesday, February 20, 2007 > Hello! > > there is a critical issues in PHP 4.4.5: > - when register_globals = On, sessions don't work correctly (segfaults). > > Because of this I'd like to release a 4.4.6 soon with this fixes. As > there is also an upgrade to pcre 7.0 we'd need atleast one RC, which I > plan to release on Thursday. > > Any opinions? > > regards, > Derick ------=_NextPart_000_0107_01C7555D.37143860 Content-Type: text/plain; name="bug40115_4_4.diff.txt" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="bug40115_4_4.diff.txt" Index: zend_operators.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /repository/Zend/Attic/zend_operators.c,v=0A= retrieving revision 1.129.2.10.2.2=0A= diff -u -r1.129.2.10.2.2 zend_operators.c=0A= --- zend_operators.c 3 Oct 2006 17:55:40 -0000 1.129.2.10.2.2=0A= +++ zend_operators.c 18 Jan 2007 10:53:59 -0000=0A= @@ -1737,8 +1737,7 @@=0A= result->value.lval =3D ZEND_NORMALIZE_BOOL(result->value.dval);=0A= result->type =3D IS_LONG;=0A= } else { /* they both have to be long's */=0A= - result->value.lval =3D lval1 - lval2;=0A= - result->value.lval =3D ZEND_NORMALIZE_BOOL(result->value.lval);=0A= + result->value.lval =3D lval1 > lval2 ? 1 : (lval1 < lval2 ? -1 : 0);=0A= result->type =3D IS_LONG;=0A= }=0A= } else {=0A= ------=_NextPart_000_0107_01C7555D.37143860--