Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:28025 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12323 invoked by uid 1010); 15 Feb 2007 14:22:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 12307 invoked from network); 15 Feb 2007 14:22:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Feb 2007 14:22:31 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.162.230 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 64.233.162.230 nz-out-0506.google.com Linux 2.4/2.6 Received: from [64.233.162.230] ([64.233.162.230:6131] helo=nz-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DD/16-33779-7AC64D54 for ; Thu, 15 Feb 2007 09:22:31 -0500 Received: by nz-out-0506.google.com with SMTP id k1so590650nzf for ; Thu, 15 Feb 2007 06:22:29 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=m6gjW5MCodhbAw8R5Rgyp+G0lcQpSOrjtL9H48+7Ep7BF0rpeFWsJpKzObZw4FR22TnhvgYlA/rOmCqPrOLtoPJh+kZXyYgdZ+3cG5A24pIn0f7A1bOICA1J2LXH8dlc6laEeZ/aCFUNdFwOuuDlRz4fhq/8YpQSWK1k4p/mxe0= Received: by 10.65.121.9 with SMTP id y9mr2863658qbm.1171549348960; Thu, 15 Feb 2007 06:22:28 -0800 (PST) Received: by 10.64.148.9 with HTTP; Thu, 15 Feb 2007 06:22:28 -0800 (PST) Message-ID: Date: Thu, 15 Feb 2007 15:22:28 +0100 To: "Dmitry Stogov" Cc: "Sara Golemon" , "Andrei Zmievski" , "Andi Gutmans" , "Rasmus Lerdorf" , internals@lists.php.net In-Reply-To: <000001c75030$b1825730$6e02a8c0@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <000001c75030$b1825730$6e02a8c0@thinkpad> Subject: Re: runtime JIT From: pierre.php@gmail.com (Pierre) Hi Dmitry! On 2/14/07, Dmitry Stogov wrote: > The patch is attached. > > To use runtime JIT you will need to change zend_register_auto_global() to > zend_register_auto_global_ex() with "1" as the last argument. Compile-time > JIT is still supported too. > > Note that the significant part of the patch is reverting of "autoglobals CV" > patch, that is reimplemented using CG(auto_globals_cache). > > Any objections? The patch looks good and it implements the concept I described in my initial proposal. So no, no objection here. For the record, what needs to be done now is (after a short discussion with Dmitry): - implement the callback to decode the input - support multiple calls of http_input_encoding, GPC must be re-encoded (rearm JIT) a new function is required and a couple of changes in the hash creations (call dtor, etc.) - Add test cases - Implement unicode support in ext/filter I do not have the time to test and work on that until next week on Wednesday. If someone likes to work on one part or another, please raise the hand :) Thanks for your work! --Pierre