Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27982
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain officinedigitali.it from 85.18.95.71 cause and error)
Message-ID: <45CDCD4D.7000605@officinedigitali.it>
Date: Sat, 10 Feb 2007 14:49:01 +0100
User-Agent: Mozilla Thunderbird 1.0.7-4mdk (X11/20051221)
MIME-Version: 1.0
To:  internals@lists.php.net
References: <45CC1984.6010304@pooteeweet.org> <45CCAAF3.2030806@officinedigitali.it> <45CCDA75.9020404@bitflux.ch>
In-Reply-To: <45CCDA75.9020404@bitflux.ch>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: DOM recover error reporting mode
From: nsabbi@officinedigitali.it (nico)

Christian Stocker wrote:

>On 9.2.2007 18:10 Uhr, Nico Sabbi wrote:
>  
>
>>may I re-propose the attached patch? The first time it was ignored, but
>>the current behaviour of
>>dom module is extremely annoying
>>    
>>
>
>Completely out of context your post, but I was the one who wrote that
>part of code, since I was more or less forced to implement it the way it
>is.
>
>I'm fine with removing it, but there were big objections against the
>whole recover stuff back then when I committed it, so the way it works
>currently was some kind of compromise
>
>See also:
>http://blog.bitflux.ch/archive/2004/08/13/parsing_non_well_formed_xml_documents_in_php.html
>http://blog.bitflux.ch/archive/2004/08/20/parsing_non_well_formed_xml_documents_considered_harmful.html
>
>and don't forget the comments :)
>  
>

I see, but in my opinion since the recover mode is off by default and
E_WARNING is on by default, if recover mode is explicitly activated
php should respect the developer's need to keep the interpreter as quiet 
as possible.
A developer with more stringent needs will either keep recover mode off
or activate it alongside with E_WARNING.

BTW, I've seen thousand of xml docs declared "broken" not for syntax 
errors, but
for the simple presence of characters not corresponding the the encoding 
specified...

    Nico