Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27952
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain officinedigitali.it from 194.244.215.2 cause and error)
Message-ID: <45CCAAF3.2030806@officinedigitali.it>
Date: Fri, 09 Feb 2007 18:10:11 +0100
User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040803)
MIME-Version: 1.0
To:  internals@lists.php.net
References: <45CC1984.6010304@pooteeweet.org>
In-Reply-To: <45CC1984.6010304@pooteeweet.org>
Content-Type: multipart/mixed;
 boundary="------------030404030102080300050804"
Subject: Re: [PHP-DEV] todo items
From: nsabbi@officinedigitali.it (Nico Sabbi)

--------------030404030102080300050804
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Lukas Kahwe Smith wrote:

> Hello,
>
> On the heels of the 5.2.1 release I just wanted to bring up the 
> following todo items that have been on the 5.x todo lists since ages. 
> Are these still alive? Have they been done? What would be a sensible 
> target version?
>
> Especially the "on-the-fly static properties" is much requested.
>
> Open for discussion
>
>    1. on-the-fly static properties (mike)
>    2. 'strict class' to disable dynamic member variable addition (marcus)
>    3. add a function that returns tsrm_thread_id() - already covererd 
> by zend_thread_id() but only in debug ZTS mode (Wez)
>    4. userspace streams filter that acts as a default filter through 
> which require/include read their files (Sebastian, Sara)
>    5. pat3 "OpenLDAP C API cleanup patch" and pat44 "LDAP control 
> support"
>

may I re-propose the attached patch? The first time it was ignored, but 
the current behaviour of
dom module is extremely annoying


--------------030404030102080300050804
Content-Type: text/x-patch;
 name="dom.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="dom.diff"

--- ext/dom/document.c.orig	2006-01-01 13:50:06.000000000 +0100
+++ ext/dom/document.c	2006-11-03 10:53:18.000000000 +0100
@@ -1512,18 +1512,11 @@
 #endif
 
 	ctxt->recovery = recover;
-	if (recover) {
-		old_error_reporting = EG(error_reporting);
-		EG(error_reporting) = old_error_reporting | E_WARNING;
-	}
 
 	xmlParseDocument(ctxt);
 
 	if (ctxt->wellFormed || recover) {
 		ret = ctxt->myDoc;
-		if (ctxt->recovery) {
-			EG(error_reporting) = old_error_reporting;
-		}
 		/* If loading from memory, set the base reference uri for the document */
 		if (ret->URL == NULL && ctxt->directory != NULL) {
 			ret->URL = xmlStrdup(ctxt->directory);


--------------030404030102080300050804--