Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:27794 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26150 invoked by uid 1010); 5 Feb 2007 09:16:25 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26133 invoked from network); 5 Feb 2007 09:16:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Feb 2007 09:16:25 -0000 Authentication-Results: pb1.pair.com smtp.mail=xuefer@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=xuefer@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.174 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: xuefer@gmail.com X-Host-Fingerprint: 66.249.92.174 ug-out-1314.google.com Linux 2.4/2.6 Received: from [66.249.92.174] ([66.249.92.174:51827] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3C/CE-18726-8E5F6C54 for ; Mon, 05 Feb 2007 04:16:24 -0500 Received: by ug-out-1314.google.com with SMTP id o4so1223336uge for ; Mon, 05 Feb 2007 01:16:21 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=hwJL4vLj/IS9BQrdXC9c/qVv1VsXFU8UEbTjOUGMAwG4dwPKYWrdC8AoNDmHNEHAZ9LybszgKicif6pQ+wWKICpsgllaYinZI0bCcII89orWChgqCPfCKZqMkXqEfQ5FUapsRZx77A4egK+eH3V1EQGVhDsXuVzA3EWtibralmQ= Received: by 10.78.204.20 with SMTP id b20mr1052334hug.1170666980983; Mon, 05 Feb 2007 01:16:20 -0800 (PST) Received: by 10.78.206.11 with HTTP; Mon, 5 Feb 2007 01:16:20 -0800 (PST) Message-ID: <28139bc0702050116t1a9f203flb4655cee6c88f6b@mail.gmail.com> Date: Mon, 5 Feb 2007 17:16:20 +0800 To: PHPdev MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: time to remove useless dirty hack From: xuefer@gmail.com (Xuefer) ZendEngine2/zend_compile.c opline->result.op_type = IS_CONST; /* FIXME: Hack so that INIT_FCALL_BY_NAME still knows this is a class */ i checked cvs log (and hardly) find that this hack was for php 5.0-rc/betas, not even used in 5.0. can anyone think about it and change it back to IS_TMP_VAR? it's the only hack that makes opcode dirty as far as i know.