Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27479
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 81.169.182.136 cause and error)
Date: Tue, 16 Jan 2007 10:07:06 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <715503765.20070116100706@marcus-boerger.de>
To: Derick Rethans <derick@php.net>
Cc: PHP Developers Mailing List <internals@lists.php.net>
In-Reply-To: <Pine.LNX.4.62.0701160015470.3723@localhost>
References: <287851093.20070115233131@marcus-boerger.de> <Pine.LNX.4.62.0701160015470.3723@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Help debugging overloaded objects
From: helly@php.net (Marcus Boerger)

Hello Derick,

  I changed the code now to be easier understandable. In the patch
the following happens. In the two if cases properties get initialized
and in the third case where none of the ifs apply properties will remain
NULL. Now in the later code is_temp isonlybeingused if properties is not
NULL. Anyway i made the code more readable.

best regards
marcus

Tuesday, January 16, 2007, 12:17:04 AM, you wrote:

> On Mon, 15 Jan 2007, Marcus Boerger wrote:

>> Any comments?

> Shouldn't you init is_temp here? As far as I can see it is not initialized in
> every code path, and there is an if() using it in the 3rd patch element here:

>> @@ -581,6 +581,7 @@ ZEND_API void zend_print_zval_r_ex(zend_
>>                                 HashTable *properties = NULL;
>>                                 zstr class_name = NULL_ZSTR;
>>                                 zend_uint clen;
>> +                               int is_temp;
>> 
>> 
>>                                 if (Z_OBJ_HANDLER_P(expr, get_class_name)) {
>>                                         Z_OBJ_HANDLER_P(expr, get_class_name)(expr, &class_name, &clen, 0 TSRMLS_CC);
>> @@ -593,8 +594,11 @@ ZEND_API void zend_print_zval_r_ex(zend_
>>                                 if (class_name.v) {
>>                                         efree(class_name.v);
>>                                 }
>> -                               if (Z_OBJ_HANDLER_P(expr, get_properties)) {
>> +                               if (Z_OBJ_HANDLER_P(expr, get_debug_info)) {
>> +                                       properties = Z_OBJ_HANDLER_P(expr, get_debug_info)(expr, &is_temp TSRMLS_CC);
>> +                               } else if (Z_OBJ_HANDLER_P(expr, get_properties)) {
>>                                         properties = Z_OBJPROP_P(expr);
>> +                                       is_temp = 0;
>>                                 }
>>                                 if (properties) {
>>                                         if (++properties->nApplyCount>1) {
>> @@ -604,6 +608,10 @@ ZEND_API void zend_print_zval_r_ex(zend_
>>                                         }
>>                                         print_hash(properties, indent, 1 TSRMLS_CC);
>>                                         properties->nApplyCount--;
>> +                                       if (is_temp) {
>> +                                               zend_hash_destroy(properties);
>> +                                               efree(properties);
>> +                                       }
>>                                 }
>>                                 break;
>>                         }

> regards,
> Derick
> -- 
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org




Best regards,
 Marcus