Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27307
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.169 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=IyfH/TI509Vzravivapm8TdBonGjoTNCEUkFxUs47hZUrigY0jmm/fK0Pl0jBI3b7W2T1cOuVyg2YVo1vsqjhY8ujP0Za+VJG2s30jvQMXhmLXUEg99t325MVfDXhQsHReX5sbnlqBHH7ouswvqDhI+9ie2nAxpnvgB+35W+DhQ=
Message-ID: <fe05d1540701061243m2075c3f5qec47a73cd3024269@mail.gmail.com>
Date: Sat, 6 Jan 2007 21:43:42 +0100
To: "Moritz Bechler" <mbechler@eenterphace.org>
Cc: internals@lists.php.net
In-Reply-To: <ivb574-skl.ln1@server2.eenterphace.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <ivb574-skl.ln1@server2.eenterphace.org>
Subject: Re: [PHP-DEV] [PATCH] OpenSSL CRL Support
From: pierre.php@gmail.com (Pierre)

Hello Moritz,

On 1/6/07, Moritz Bechler <mbechler@eenterphace.org> wrote:
> Hi,
>
> I already asked for comments on inclusion of OpenSSL CRL support in
> ext/openssl some time ago (I had a independend extension at this point).

Do you have a bug id please? If not please open one.

> As I continued working on it I realized that making this an independend
> extension makes me to reinvent/reimplement the wheel and makes it
> impossible to have ext/openssl and the CRL support to integrate nicely,
> so I wrote a patch to include it in ext/openssl.
>
> In fact, having Marc Delling's PKCS#12 patch and mine applied makes it
> possible to write basic but real PKI-CA applications in PHP, so I think
> it would be nice to have this.

This patch is in the queue. There is a bug report about it. I will add
the pending patches to the next development branch for 5.x and HEAD
once 5.2.1 is out.

> I know that there are not that many people who need this but I think
> this is true for nearly the whole openssl extension except for the
> stream wrapper. (maybe we should consider splitting it up?)

Even if not many people needs openssl functions, the needs are here
and it is a pain when a feature is missing.

> You find a patch (hopefully I got your conding standards right ;))
> attached, but I should take careful review because this actually is my
> first work on PHP extensions and I'm also not used to writing C code.
> I can/will provide a test (what kind of tests should I supply?) and
> documentation when needed.

Thanks for patch!

Can you put it in a bug report so it will not get lost? And you will
be informed as soon as it is committed.

Regards,
--Pierre