Newsgroups: php.internals,php.internals Path: news.php.net Xref: news.php.net php.internals:27216 php.internals:27217 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29773 invoked by uid 1010); 29 Dec 2006 23:52:40 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 29758 invoked from network); 29 Dec 2006 23:52:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Dec 2006 23:52:40 -0000 X-Host-Fingerprint: 82.239.75.164 vol75-9-82-239-75-164.fbx.proxad.net Received: from [82.239.75.164] ([82.239.75.164:12441] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 35/C1-09304-74AA5954 for ; Fri, 29 Dec 2006 18:52:40 -0500 To: internals@lists.php.net,Nuno Lopes Message-ID: <4595AA42.70802@php.net> Date: Sat, 30 Dec 2006 00:52:34 +0100 User-Agent: Debian Thunderbird 1.0.2 (X11/20060830) X-Accept-Language: en-us, en MIME-Version: 1.0 CC: Pierre , internals@lists.php.net, Sara Golemon References: <45950E67.9000203@php.net> <002d01c72b57$7893cdd0$0100a8c0@pc07653> In-Reply-To: <002d01c72b57$7893cdd0$0100a8c0@pc07653> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Posted-By: 82.239.75.164 Subject: Re: [PHP-DEV] About #37799 From: didou@php.net (Mehdi Achour) Hi, Nuno Lopes wrote: >>> I had a look at http://bugs.php.net/37799 and I would really like to >>> have a little warning added upon SSL connection failure. >>> >>> From my understanding, the silent fall back to a normal connection is >>> made in ftp.c at line 269, which as the bug reporter says, "leads to a >>> false sense of security". >> >> >> I would instead make ftp_ssl_connect failing and returns false. I >> prefer functions without too much error messages for expected errors >> (a network connection can fail, no need to raise a warning here). Then >> let the user decides to try again using ftp_connect. >> >> --Pierre > > > Yes, I have to agree here. I would also prefer returning false on > failure (as other extensions do). > > Nuno Pierre, I completely agree, user should have a real error. The problem is that ftp_ssl_connect doesn't really do the SSL connection. The silent switch is made when ftp_login() is called. If we make anyone fail, it should be ftp_login() and that would make sense. Mehdi