Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:27213 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13013 invoked by uid 1010); 29 Dec 2006 14:41:53 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 12998 invoked from network); 29 Dec 2006 14:41:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Dec 2006 14:41:53 -0000 Authentication-Results: pb1.pair.com header.from=nlopess@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=nlopess@php.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain php.net from 212.55.154.23 cause and error) X-PHP-List-Original-Sender: nlopess@php.net X-Host-Fingerprint: 212.55.154.23 relay3.ptmail.sapo.pt Linux 2.4/2.6 Received: from [212.55.154.23] ([212.55.154.23:49500] helo=sapo.pt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 82/94-12420-03925954 for ; Fri, 29 Dec 2006 09:41:53 -0500 Received: (qmail 27893 invoked from network); 29 Dec 2006 14:41:48 -0000 Received: from unknown (HELO sapo.pt) (10.134.35.210) by relay3 with SMTP; 29 Dec 2006 14:41:48 -0000 Received: (qmail 12367 invoked from network); 29 Dec 2006 14:41:48 -0000 X-AntiVirus: PTMail-AV 0.3-0.88.6 X-Virus-Status: Clean (0.01047 seconds) Received: from unknown (HELO pc07653) (nunoplopes@sapo.pt@[82.155.74.150]) (envelope-sender ) by mta15 (qmail-ldap-1.03) with SMTP for ; 29 Dec 2006 14:41:48 -0000 Message-ID: <002d01c72b57$7893cdd0$0100a8c0@pc07653> To: "Pierre" , "Mehdi Achour" Cc: , "Sara Golemon" References: <45950E67.9000203@php.net> Date: Fri, 29 Dec 2006 14:41:47 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.3028 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3028 Subject: Re: [PHP-DEV] About #37799 From: nlopess@php.net ("Nuno Lopes") >> I had a look at http://bugs.php.net/37799 and I would really like to >> have a little warning added upon SSL connection failure. >> >> From my understanding, the silent fall back to a normal connection is >> made in ftp.c at line 269, which as the bug reporter says, "leads to a >> false sense of security". > > I would instead make ftp_ssl_connect failing and returns false. I > prefer functions without too much error messages for expected errors > (a network connection can fail, no need to raise a warning here). Then > let the user decides to try again using ftp_connect. > > --Pierre Yes, I have to agree here. I would also prefer returning false on failure (as other extensions do). Nuno P.S.: nice comeback, didou ;)