Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27181
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.142.136.132 cause and error)
Message-ID: <023001c725dc$bb9b04c0$0201a8c0@pc1>
To: <internals@lists.php.net>, "Ilia Alshanetsky" <ilia@prohost.org>
References: <00a901c72586$f7e7afb0$0201a8c0@pc1> <043EF248-A4B4-438F-B738-834A5770A2D9@prohost.org>
Date: Fri, 22 Dec 2006 09:20:34 -0600
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Small date() optimization
From: php_lists@realplain.com ("Matt Wilmas")

Hi Ilia,

Oh I know that. :-)  I'm just talking about if there's a backslash as the
last character.  For example, date('U\\') (U\ passed after script parsing),
the backslash is gone, which doesn't seem correct...  (Actually, it
"appends" the '\0'.)


Matt


----- Original Message -----
From: "Ilia Alshanetsky"
Sent: Friday, December 22, 2006

> Matt,
>
> The backslash removal is actually intentional. It is designed to
> handle instances such as "\d", in which case the format value is
> printed as a literal "d".
>
>
> On 22-Dec-06, at 12:06 AM, Matt Wilmas wrote:
>
> > Hi,
> >
> > Just a simple patch for 5.2 to save smart_str_appends()'s strlen()
> > calls in
> > date_format().  It's already done in HEAD.  Seems pretty safe for
> > 5.2.1. :-)
> >
> > I also noticed that if the format string contains a backslash as
> > the last
> > character, it is lost (should be printed right?).  So I changed
> > that too and
> > attached the patch for HEAD.
> >
> > 5.2's patch:
> > http://realplain.com/php/date_optimization_5_2.diff
> >
> >
> > Matt
>
> Ilia Alshanetsky