Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27180
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.82.238 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:in-reply-to:references:mime-version:x-priority:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender;
        b=XDkm1VcGI55MI57fG9bWGDYDwJEw1qtRDwHwbIpwBpeM/upsBRCNaovmBandagrNWH6sIn9i0K8IgEZfwB0+rd6ii+IKZrJAc8RrdwOgfeUXeTaKos97GWezgRw4znV9mblIc7hNX1xG1AM1mFyc0V+lsQc8T9SusmsXHyrqKNo=
In-Reply-To: <00a901c72586$f7e7afb0$0201a8c0@pc1>
References: <00a901c72586$f7e7afb0$0201a8c0@pc1>
Mime-Version: 1.0 (Apple Message framework v752.3)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <043EF248-A4B4-438F-B738-834A5770A2D9@prohost.org>
Cc: <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Date: Fri, 22 Dec 2006 10:07:10 -0500
To: Matt Wilmas <php_lists@realplain.com>
Sender: Ilia Alshanetsky <iliaal@gmail.com>
Subject: Re: [PHP-DEV] [PATCH] Small date() optimization
From: ilia@prohost.org (Ilia Alshanetsky)

Matt,

The backslash removal is actually intentional. It is designed to  
handle instances such as "\d", in which case the format value is  
printed as a literal "d".


On 22-Dec-06, at 12:06 AM, Matt Wilmas wrote:

> Hi,
>
> Just a simple patch for 5.2 to save smart_str_appends()'s strlen()  
> calls in
> date_format().  It's already done in HEAD.  Seems pretty safe for  
> 5.2.1. :-)
>
> I also noticed that if the format string contains a backslash as  
> the last
> character, it is lost (should be printed right?).  So I changed  
> that too and
> attached the patch for HEAD.
>
> 5.2's patch:
> http://realplain.com/php/date_optimization_5_2.diff
>
>
> Matt
> <date_backslash.diff.txt>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

Ilia Alshanetsky