Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:27173
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain yahoo.com from 206.190.49.161 cause and error)
DomainKey-Status: bad
Message-ID: <20061222012248.8324.qmail@web54511.mail.yahoo.com>
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID;
  b=4MrLIiMjIfNz42EntqnnAfsR6dzN9E+2yjyuk08VG7uPcYIsRxgHmuXbRFBjJjW9FkjY5OYbiDQzbIBAEfCirFb6uTxUKTWa0hn4sx5rfYxMPMxG9/ntxf4/Y21YYuxzo6cAanync+UVKQzzzPMlVZQbvmkWBHs5QNbxbbOGjAc=;
Date: Fri, 22 Dec 2006 12:22:48 +1100 (EST)
Reply-To: toomuchphp-phpdev@yahoo.com
To: internals@lists.php.net
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Patch: recursive call to __get() error
From: toomuchphp-phpdev@yahoo.com (Peter Hodge)

Hello,

This patch for 5.2 provides an alternative error when you accidentally call
__get() recursively when trying to access some property of a class.
Currently, PHP says:

  "Notice: Undefined property: someClass::$someProperty"

which makes it seem as though __get() is not called at all.  This patch changes
the error to:

  "Warning: Recursive call to __get() trying to read property: 
someClass::$someProperty"

regards,
Peter



--- Zend.original/zend_object_handlers.c	Fri Dec 22 10:36:32 2006
+++ Zend/zend_object_handlers.c	Fri Dec 22 10:47:29 2006
@@ -325,30 +325,40 @@
 		zend_guard *guard;
 
 		if (zobj->ce->__get &&
-		    zend_get_property_guard(zobj, property_info, member, &guard) == SUCCESS
&&
-		    !guard->in_get) {
-			/* have getter - try with it! */
-			guard->in_get = 1; /* prevent circular getting */
-			rv = zend_std_call_getter(object, member TSRMLS_CC);
-			guard->in_get = 0;
+		    zend_get_property_guard(zobj, property_info, member, &guard) == SUCCESS)
{
+			/* only if not already in __get() */
+		    if(!guard->in_get) {
+				/* have getter - try with it! */
+				guard->in_get = 1; /* prevent circular getting */
+				rv = zend_std_call_getter(object, member TSRMLS_CC);
+				guard->in_get = 0;
 
-			if (rv) {
-				retval = &rv;
-				if (type == BP_VAR_W || type == BP_VAR_RW  || type == BP_VAR_UNSET) {
-					if (rv->refcount > 0) {
-						zval *tmp = rv;
+				if (rv) {
+					retval = &rv;
+					if (type == BP_VAR_W || type == BP_VAR_RW  || type == BP_VAR_UNSET) {
+						if (rv->refcount > 0) {
+							zval *tmp = rv;
 
-						ALLOC_ZVAL(rv);
-						*rv = *tmp;
-						zval_copy_ctor(rv);
-						rv->is_ref = 0;
-						rv->refcount = 0;
-					}
-					if (Z_TYPE_P(rv) != IS_OBJECT) {
-						zend_error(E_NOTICE, "Indirect modification of overloaded property
%s::$%s has no effect", zobj->ce->name, Z_STRVAL_P(member));
+							ALLOC_ZVAL(rv);
+							*rv = *tmp;
+							zval_copy_ctor(rv);
+							rv->is_ref = 0;
+							rv->refcount = 0;
+						}
+						if (Z_TYPE_P(rv) != IS_OBJECT) {
+							zend_error(E_NOTICE, "Indirect modification of overloaded property
%s::$%s has no effect", zobj->ce->name, Z_STRVAL_P(member));
+						}
 					}
+				} else {
+					retval = &EG(uninitialized_zval_ptr);
+				}
+			}
+			else {
+				/* already in __get() */
+				if (!silent) {
+					zend_error(E_WARNING, "Recursive call to __get() trying to read property:
 %s::$%s",
+						zobj->ce->name, Z_STRVAL_P(member));
 				}
-			} else {
 				retval = &EG(uninitialized_zval_ptr);
 			}
 		} else {


Send instant messages to your online friends http://au.messenger.yahoo.com