Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:27131 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78023 invoked by uid 1010); 20 Dec 2006 02:37:34 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 78008 invoked from network); 20 Dec 2006 02:37:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Dec 2006 02:37:34 -0000 Authentication-Results: pb1.pair.com header.from=php_lists@realplain.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=php_lists@realplain.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain realplain.com from 209.142.136.132 cause and error) X-PHP-List-Original-Sender: php_lists@realplain.com X-Host-Fingerprint: 209.142.136.132 msa2-mx.centurytel.net Linux 2.4/2.6 Received: from [209.142.136.132] ([209.142.136.132:58299] helo=msa2-mx.centurytel.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4D/92-53121-BC1A8854 for ; Tue, 19 Dec 2006 21:37:34 -0500 Received: from pc1 (d20-160.rt-bras.wnvl.centurytel.net [69.179.147.160]) by msa2-mx.centurytel.net (8.13.6/8.13.6) with SMTP id kBK2asmx023707; Tue, 19 Dec 2006 20:36:54 -0600 Message-ID: <013d01c723df$b7a4ab90$0201a8c0@pc1> To: , "Andrei Zmievski" References: <4582F5B3.3060201@php.net> <99a4c87054f1f6b70f68fe20772496f3@gravitonic.com> <00b801c72314$8ade21c0$0201a8c0@pc1> Date: Tue, 19 Dec 2006 20:36:56 -0600 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_013A_01C723AD.6CCE9220" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1807 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1896 Subject: Re: [PHP-DEV] Re: Unicode support for *printf() From: php_lists@realplain.com ("Matt Wilmas") ------=_NextPart_000_013A_01C723AD.6CCE9220 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Hi Andrei, Yeah, I see the patch you committed also included the changes that were made since my reply yesterday... I've attached a patch that removes a few lines that aren't present in the non-Unicode version. Matt ----- Original Message ----- From: "Andrei Zmievski" Sent: Tuesday, December 19, 2006 > Is this better? > > > -Andrei > > On Dec 18, 2006, at 6:22 PM, Matt Wilmas wrote: > > > Hi Andrei, > > > > Just a couple things I noticed in _appenddouble... In the first > > switch (), > > 'F' is being changed to 'f', and in the second switch, 'F' needs to be > > moved > > down with 'f'. Those changes were just made in v1.89 of the file. > > > > > > Matt ------=_NextPart_000_013A_01C723AD.6CCE9220 Content-Type: text/plain; name="formatted_print.diff.txt" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="formatted_print.diff.txt" Index: ext/standard/formatted_print.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /repository/php-src/ext/standard/formatted_print.c,v=0A= retrieving revision 1.92=0A= diff -u -r1.92 formatted_print.c=0A= --- ext/standard/formatted_print.c 19 Dec 2006 18:41:40 -0000 1.92=0A= +++ ext/standard/formatted_print.c 20 Dec 2006 02:20:06 -0000=0A= @@ -431,7 +431,7 @@=0A= TSRMLS_DC)=0A= {=0A= char num_buf[NUM_BUF_SIZE];=0A= - char *s =3D NULL, *q, s_fmt;=0A= + char *s =3D NULL, s_fmt;=0A= UChar *uni_s;=0A= int s_len =3D 0, is_negative =3D 0;=0A= #ifdef HAVE_LOCALE_H=0A= @@ -506,7 +506,6 @@=0A= s =3D num_buf;=0A= s_len++;=0A= }=0A= - s[s_len] =3D '\0';=0A= break;=0A= =0A= case 0x67 /* 'g' */:=0A= @@ -530,10 +529,6 @@=0A= }=0A= =0A= s_len =3D strlen(s);=0A= -=0A= - if (fmt =3D=3D 0x47 /* 'G' */ && (q =3D strchr(s, 'e')) !=3D NULL) {=0A= - *q =3D 'E';=0A= - }=0A= break;=0A= }=0A= ------=_NextPart_000_013A_01C723AD.6CCE9220--