Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26957 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14542 invoked by uid 1010); 14 Dec 2006 17:17:52 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 14527 invoked from network); 14 Dec 2006 17:17:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Dec 2006 17:17:52 -0000 Authentication-Results: pb1.pair.com header.from=andrei@gravitonic.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=andrei@gravitonic.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain gravitonic.com from 204.11.219.139 cause and error) X-PHP-List-Original-Sender: andrei@gravitonic.com X-Host-Fingerprint: 204.11.219.139 lerdorf.com Linux 2.5 (sometimes 2.4) (4) Received: from [204.11.219.139] ([204.11.219.139:44223] helo=lerdorf.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AB/AF-04864-AF681854 for ; Thu, 14 Dec 2006 12:17:17 -0500 Received: from [66.228.175.145] (borndress-lm.corp.yahoo.com [66.228.175.145]) (authenticated bits=0) by lerdorf.com (8.13.8/8.13.8/Debian-3) with ESMTP id kBEHGd7v004435; Thu, 14 Dec 2006 09:16:39 -0800 In-Reply-To: References: <10.23.32177.CA640854@pb1.pair.com> <2da4c44996eb06fb90d7141e5e5ebc02@gravitonic.com> Mime-Version: 1.0 (Apple Message framework v624) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-ID: Content-Transfer-Encoding: 7bit Cc: internals@lists.php.net Date: Thu, 14 Dec 2006 09:16:53 -0800 To: "Ron Korving" X-Mailer: Apple Mail (2.624) Subject: Re: [PHP-DEV] [PATCH] 1 small optimization and 1 cleanup From: andrei@gravitonic.com (Andrei Zmievski) Sure. On Dec 14, 2006, at 9:07 AM, Ron Korving wrote: > I can redo the patch if you want. I do notice the braces aren't always > used > in if-statements (see preg_get_backref() for a few occasions). Do you > want > me to repost it with braces? > > - Ron > > > "Andrei Zmievski" wrote in message > news:2da4c44996eb06fb90d7141e5e5ebc02@gravitonic.com... >> >> On Dec 13, 2006, at 10:28 AM, Ron Korving wrote: >> >>> + >>> + if (pce) >>> + { >>> + if (extra) *extra = pce->extra; >>> + if (preg_options) *preg_options = pce->preg_options; >>> + if (compile_options) *compile_options = pce->compile_options; >>> + return pce->re; >>> } >> >> If you rewrite it, then please adhere to the code style that was used, >> i.e. with explicit braces for if() statements. >> >> -Andrei > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php