Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26956 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7832 invoked by uid 1010); 14 Dec 2006 17:09:40 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7816 invoked from network); 14 Dec 2006 17:09:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Dec 2006 17:09:40 -0000 X-Host-Fingerprint: 83.160.219.156 korving.demon.nl Received: from [83.160.219.156] ([83.160.219.156:5517] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AD/BE-04864-13581854 for ; Thu, 14 Dec 2006 12:09:40 -0500 Message-ID: To: internals@lists.php.net References: <10.23.32177.CA640854@pb1.pair.com> <2da4c44996eb06fb90d7141e5e5ebc02@gravitonic.com> Date: Thu, 14 Dec 2006 18:07:58 +0100 Lines: 27 X-Priority: 3 X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 6.00.2800.1437 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441 X-Posted-By: 83.160.219.156 Subject: Re: [PHP-DEV] [PATCH] 1 small optimization and 1 cleanup From: r.korving@xit.nl ("Ron Korving") I can redo the patch if you want. I do notice the braces aren't always used in if-statements (see preg_get_backref() for a few occasions). Do you want me to repost it with braces? - Ron "Andrei Zmievski" wrote in message news:2da4c44996eb06fb90d7141e5e5ebc02@gravitonic.com... > > On Dec 13, 2006, at 10:28 AM, Ron Korving wrote: > > > + > > + if (pce) > > + { > > + if (extra) *extra = pce->extra; > > + if (preg_options) *preg_options = pce->preg_options; > > + if (compile_options) *compile_options = pce->compile_options; > > + return pce->re; > > } > > If you rewrite it, then please adhere to the code style that was used, > i.e. with explicit braces for if() statements. > > -Andrei