Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26911
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.142.136.132 cause and error)
Message-ID: <018301c71e06$9ef4f840$0201a8c0@pc1>
To: <internals@lists.php.net>, "Ilia Alshanetsky" <ilia@prohost.org>
References: <014f01c71dfd$f0431cd0$0201a8c0@pc1> <F518403D-5926-4065-886A-E9CF8CF60914@prohost.org>
Date: Tue, 12 Dec 2006 10:00:16 -0600
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] New, optimized is_numeric_string, and other number stuff
From: php_lists@realplain.com ("Matt Wilmas")

Hi Ilia,

I actually changed +2 to +4. :-)

In the original message, I didn't clarify that the % improvement with
numbers was obtained using arithmetic operators with one numeric string
operand.  And the number changes in the parser just made a few % difference
in my crude way of trying to test it (repeated "<number>; ..." passed to
eval()).

There are also many compiler warnings now in is_numeric_unicode() on
zend_cmp_unicode_and_literal(), because its parameters aren't declared
const...


Matt


----- Original Message -----
From: "Ilia Alshanetsky"
Sent: Tuesday, December 12, 2006

> Matt,
>
> The zend_exceptions.c bit seems incorrect. You change +4 to +2 but
> there are 4 "text" chars that need to be accounted for there. I am
> going over the rest of the patch now.
>
> Ilia Alshanetsky