Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26889 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9791 invoked by uid 1010); 10 Dec 2006 19:44:39 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 9776 invoked from network); 10 Dec 2006 19:44:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Dec 2006 19:44:39 -0000 Authentication-Results: pb1.pair.com smtp.mail=iliaal@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=iliaal@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.162.238 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: iliaal@gmail.com X-Host-Fingerprint: 64.233.162.238 nz-out-0506.google.com Linux 2.4/2.6 Received: from [64.233.162.238] ([64.233.162.238:49827] helo=nz-out-0102.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5E/AC-00543-1636C754 for ; Sun, 10 Dec 2006 14:44:04 -0500 Received: by nz-out-0102.google.com with SMTP id k1so815305nzf for ; Sun, 10 Dec 2006 11:43:26 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=MrKlhfRxQ5GA3By3SbzTdvZ3OiJI2llfvL4YgDcCxeMW4Y9fLMIzdjg37mNgUdxm1xqzDneZH9e53HD9Wjlrnz0cytIi0VeJUAmx/remLlt2F5yssehByidTOvTpAY1867P8tp+1UH/iN3AzsBXMddJsWgGEQbqkhbOGFsmaoDI= Received: by 10.65.154.4 with SMTP id g4mr9416433qbo.1165779806718; Sun, 10 Dec 2006 11:43:26 -0800 (PST) Received: from ?192.168.1.6? ( [74.108.69.82]) by mx.google.com with ESMTP id d2sm5586839qbc.2006.12.10.11.43.26; Sun, 10 Dec 2006 11:43:26 -0800 (PST) In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: <6955364B-DD7D-4305-8270-88362C94606F@prohost.org> Cc: PHP internals Content-Transfer-Encoding: 7bit Date: Sun, 10 Dec 2006 14:43:13 -0500 To: Brian Shire X-Mailer: Apple Mail (2.752.3) Sender: Ilia Alshanetsky Subject: Re: [PHP-DEV] extract() optimization From: ilia@prohost.org (Ilia Alshanetsky) On 9-Dec-06, at 3:24 PM, Brian Shire wrote: > This patch should safely remove what appears to be unnecessary > strlen() calls for php_valid_var_name() used by extract(). Good catch, thanks. The patch is now in the CVS. Ilia Alshanetsky