Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26822
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 140.211.166.39 cause and error)
DomainKey-Status: good
DomainKey-Signature: q=dns; a=rsa-sha1; c=nofws;
	s=mx; d=php.net;
	h=From:Subject:To:Date;
	b=G1iaZJnDKHEKx1qqJRgDgeqgpa2bFwec83CI32reXYeneXK23FICWg7TGakBoNvq
	re8Ax02kC+mJEG7kdbyq4jbyeBxQ+0hJtO1R/fo+vdzI4vabo4ECMmjuCyH12pod
Message-ID: <4576F096.8070803@php.net>
Date: Wed, 06 Dec 2006 08:32:22 -0800
User-Agent: Thunderbird 1.5.0.8 (Macintosh/20061025)
MIME-Version: 1.0
To:  dmitry@zend.com
CC:  internals@lists.php.net, Andi Gutmans <andi@zend.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Function call speedup (CV applied to functions)
From: pollita@php.net (Sara Golemon)

> We had very similar idea in the past.
> BTW it is possible to optimize function calls mach more.
> Not only ZEND_DO_FCALL but also ZEND_INIT_FCALL_BY_NAME can be optimized,
> and we can reuse the same cache entries for all op_arrays from the same PHP
> file.
> 
Sure, I went shallow with this first version just to have something to 
discuss, so that general intent was clear.  There's certainly a lot that 
can be done to improve it both from a code-line coverage and in actual 
implementation (for one thing, I got a crash with it a couple days ago 
which I havn't bothered tracking down).

Making the cache per-file (rather than per-scope) would definately be a 
good direction to go (per-execution would unfortunately break opcode 
cache assumptions so we can't go that high), but I couldn't come up with 
a simple/easy way to "track" the current file.  I suppose we could use 
the op_array's filename attribute to lookup a cache vector from a 
hashtable anytime scope changes...

> I'll make a patch and send it to you in fey days.
> 

Can't wait to see it! :)

-Sara