Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26763
Return-Path: <shire@facebook.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 68438 invoked by uid 1010); 1 Dec 2006 23:47:59 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 68423 invoked from network); 1 Dec 2006 23:47:59 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 1 Dec 2006 23:47:59 -0000
Authentication-Results: pb1.pair.com smtp.mail=shire@facebook.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=shire@facebook.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain facebook.com designates 204.15.20.10 as permitted sender)
X-PHP-List-Original-Sender: shire@facebook.com
X-Host-Fingerprint: 204.15.20.10 aggr1.fw.sctm.tfbnw.net Windows 2000 SP4, XP SP1
Received: from [204.15.20.10] ([204.15.20.10:6365] helo=kitt.TheFacebook.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 42/35-35332-C0FB0754 for <internals@lists.php.net>; Fri, 01 Dec 2006 18:47:59 -0500
Received: from [172.21.200.109] ([172.21.200.109]) by kitt.TheFacebook.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830);
	 Fri, 1 Dec 2006 15:47:21 -0800
In-Reply-To: <1189866595.20061202002133@marcus-boerger.de>
References: <873756B2-DE0A-42F4-AC5A-04FFF0A42592@facebook.com> <789985652.20061201094215@marcus-boerger.de> <4C7F9544-36F0-4E82-A0AC-D81A863DC11A@facebook.com> <1189866595.20061202002133@marcus-boerger.de>
Mime-Version: 1.0 (Apple Message framework v752.3)
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <49ACA225-D92A-412E-AA3C-E444A8515051@facebook.com>
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Date: Fri, 1 Dec 2006 15:47:19 -0800
To: Marcus Boerger <helly@php.net>
X-Mailer: Apple Mail (2.752.3)
X-OriginalArrivalTime: 01 Dec 2006 23:47:21.0717 (UTC) FILETIME=[0B52B250:01C715A3]
Subject: Re: [PHP-DEV] make test flag?
From: shire@facebook.com (Brian Shire)


On Dec 1, 2006, at 3:21 PM, Marcus Boerger wrote:

> Hello Brian,
>
>   why should it do that? run-tests.php doesn't do anything with  
> extensions.
>   Meaning it only tests when you load your .so's by ini.
>


       $(PHP_EXECUTABLE) -d 'open_basedir=' -d 'safe_mode=0' -d  
'output_buffering=0' -d 'memory_limit=-1' $(top_srcdir)/run-tests.php  
-d 'extension_dir=modules/' -d `( . $(PHP_MODULES) ; echo extension=$ 
$dlname)` tests/; \

Given this only affects a make test being done in an extension that  
has been setup with a "phpize" command.  Let me know if I've  
overlooked anything.  I believe the above line that executes the  
"make test" causes two minor problems for ini files loading DSO's.   
First it sets the "extension_dir" to modules. Any attempt to load  
modules from installed ini files will fail because the path is now  
different.  The second is that the last portion loads the extension  
by doing a "-d extension=<extname>" on the php commandline, which I  
causes my "already loaded error".



> best regards
> marcus
>
> Saturday, December 2, 2006, 12:16:45 AM, you wrote:
>
>> On Dec 1, 2006, at 12:42 AM, Marcus Boerger wrote:
>
>>> Hello Brian,
>>>
>>>   therun-tests.php command will take care of any INI settings that
>>> are known
>>> to break tests.So if anyof your INI settings cause tests to failwe
>>> simply
>>> need to include them into the tests. Othewise it is important to
>>> test with
>>> your INI settings asyou want to know if your PHP installation
>>> works. Instead
>>> of knowing whether PHP in general could work.
>>>
>
>> Thanks Marcus,
>
>> The actual situation I'm thinking of is when you are running make
>> test on an extension being built as a DSO that is already configured
>> to load in an ini file.  When make test is ran it will attempt to
>> load the DSO twice, and gives: "PHP Warning:  Module 'apc' already
>> loaded in Unknown on line 0".
>
>> I thought the preference would be to ignore installed ini files, but
>> if that's not the intention, then my proposed patch of course is bad.
>
>
>> -Brian Shire
>>   shire@facebook.com
>>   shire@php.net
>>   aim: int80h
>
>
>
>
> Best regards,
>  Marcus
>

-Brian Shire
  shire@facebook.com
  shire@php.net
  aim: int80h