Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26760 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59232 invoked by uid 1010); 1 Dec 2006 23:04:26 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 59217 invoked from network); 1 Dec 2006 23:04:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Dec 2006 23:04:26 -0000 Authentication-Results: pb1.pair.com smtp.mail=iliaal@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=iliaal@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.166.177 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: iliaal@gmail.com X-Host-Fingerprint: 64.233.166.177 py-out-1112.google.com Linux 2.4/2.6 Received: from [64.233.166.177] ([64.233.166.177:22859] helo=py-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 82/B3-35332-3B4B0754 for ; Fri, 01 Dec 2006 18:03:51 -0500 Received: by py-out-1112.google.com with SMTP id a25so2040217pyi for ; Fri, 01 Dec 2006 15:03:13 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=tgexOZVHLoI2mcQ1fuDUKqqpiwlLePIeRd+xL/9Ksa8etwSA8JaJpwoTTDDzBxdf2EBIKY6OU+NutHvTSd0g/51O+umEZ6Is44Hqb5MPnVUFwm4+5Wz3xFa3H/9unvhsTWE1Swb2yfQg7FBPgIX6S4Ns/BIZupTxL08Tjp8Owp4= Received: by 10.64.199.2 with SMTP id w2mr7776972qbf.1165014193239; Fri, 01 Dec 2006 15:03:13 -0800 (PST) Received: from ?192.168.1.5? ( [74.108.69.82]) by mx.google.com with ESMTP id e15sm10186732qba.2006.12.01.15.03.11; Fri, 01 Dec 2006 15:03:12 -0800 (PST) In-Reply-To: <0c60b01d19ec7e242ade31e29120ee27@gravitonic.com> References: <0c60b01d19ec7e242ade31e29120ee27@gravitonic.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: Cc: php-dev Internals Content-Transfer-Encoding: 7bit Date: Fri, 1 Dec 2006 18:03:07 -0500 To: Andrei Zmievski X-Mailer: Apple Mail (2.752.3) Sender: Ilia Alshanetsky Subject: Re: [PHP-DEV] PHP 5.2: Serialization patch From: ilia@prohost.org (Ilia Alshanetsky) As it stands the current code breaks BC on decoding when the serialized string contains \ characters. For example: Input PHP 5.2 PHP 5.2 w/patch ------------------------------------------------------------------------ ------------------- s:7:"foo\10b"; foo\10b error (NULL returned) s:7:"foo\bar"; foo\bar error (NULL returned) s:5:"\\\\\"; \\\\\ error (NULL returned) Basically any operation involving strings with \ in them, stop working once the patch is applied. There is also the performance drawback to consider, which based on a rudimentary test involving $_SERVER serialization, shows that the new code is roughly 1/2 slower. 5.2: 0.388 5.2 w/patch: 0.652 Ilia