Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26754 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57091 invoked by uid 1010); 1 Dec 2006 19:40:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 57076 invoked from network); 1 Dec 2006 19:40:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Dec 2006 19:40:02 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:8998] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 73/D1-40958-BC480754 for ; Fri, 01 Dec 2006 14:39:27 -0500 Received: (qmail 6398 invoked from network); 1 Dec 2006 19:37:21 -0000 Received: from office.zend.office (HELO ?127.0.0.1?) (192.168.16.109) by internal.zend.office with SMTP; 1 Dec 2006 19:37:21 -0000 Message-ID: <457084C5.60008@zend.com> Date: Fri, 01 Dec 2006 11:38:45 -0800 Organization: Zend Technologies User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) MIME-Version: 1.0 To: 'PHP Internals' Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: windows build broken in php_scandir From: stas@zend.com (Stanislav Malyshev) Latest patch to php_scandir: http://cvs.php.net/viewvc.cgi/php-src/main/php_scandir.c?r1=1.12.2.1&r2=1.12.2.1.2.1 Seems to break windows build in two places: main\php_scandir.c(65) : error C2065: 'MAXPATHLEN' : undeclared identifier main\php_scandir.c(65) : error C2057: expected constant expression main\php_scandir.c(65) : error C2466: cannot allocate an array of constant size 0 main\php_scandir.c(65) : error C2133: 'entry' : unknown size main\php_scandir.c(76) : warning C4013: 'php_readdir_r' undefined; assuming extern returning int main\php_scandir.c(76) : warning C4047: '=' : 'dirent *' differs in levels of indirection from 'int' I'll try to fix it. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/