Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26743
Return-Path: <r.korving@xit.nl>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 79118 invoked by uid 1010); 30 Nov 2006 21:09:44 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 79103 invoked from network); 30 Nov 2006 21:09:44 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Nov 2006 21:09:44 -0000
X-Host-Fingerprint: 83.160.219.156 korving.demon.nl  
Received: from [83.160.219.156] ([83.160.219.156:17008] helo=localhost.localdomain)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 58/40-10594-2584F654 for <internals@lists.php.net>; Thu, 30 Nov 2006 16:09:09 -0500
Message-ID: <58.40.10594.2584F654@pb1.pair.com>
To: internals@lists.php.net
References: <74.6A.43708.5A94B654@pb1.pair.com> <773C5559-F08C-45EF-BCC1-211C26E93534@prohost.org>
Date: Thu, 30 Nov 2006 22:00:11 +0100
Lines: 83
X-Priority: 3
X-MSMail-Priority: Normal
X-Newsreader: Microsoft Outlook Express 6.00.2800.1437
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441
X-Posted-By: 83.160.219.156
Subject: Re: [PHP-DEV] thread unsafety inventory
From: r.korving@xit.nl ("Ron Korving")

Ilia,

Great work. I posted a bug report at www.sqlite.org.

Regards,

Ron Korving


"Ilia Alshanetsky" <ilia@prohost.org> wrote in message
news:773C5559-F08C-45EF-BCC1-211C26E93534@prohost.org...
>
> On 27-Nov-06, at 3:24 PM, Ron Korving wrote:
> > gmtime: (use gmtime_r)
> >
> > ext/interbase/ibase_query.c on line 679
>
> Fixed.
>
> > ext/pdo_sqlite/sqlite/src/date.c on line 948 (external code library)
>
> This code cannot be reached since we compile libsqlite with date
> functions.
>
> > sapi/thttpd_patch on lines 282, 1355, 2298
>
> External application patch, can't be helped.
>
> > ctime: (use ctime_r)
> >
> > ext/mime_magic/mime_magic.c on line 1759
>
> Fixed.
>
> > localtime: (use localtime_r)
> >
> > ext/com_dotnet/com_variant.c on line 818
>
> Win32 only code and there localtime is already thread-safe.
>
> > ext/pdo_sqlite/sqlite/src/date.c on line 415 (external code library)
> > ext/sqlite/libsqlite/src/date.c on line 419 (external code library)
> > ext/xmlrpc/libxmlrpc/xmlrpc.c on line 234 (external code library)
> > ext/zip/lib/zip_dirent.c on lines 398, 525 (external code library)
>
> Fixed. You may want to report the sqlite issues to sqlite devs so
> that they can apply a fix in their code base as well.
>
> > sapi/thttpd_patch on line 2300 (external code library)
>
> External application patch, can't be helped.
>
> > crypt: (use crypt_r)
> >
> > ext/standard/crypt.c on line 149
>
> Fixed.
>
> > rand: (use rand_r)
> >
> > ext/mcrypt/mcrypt.c on line 1042
> > ext/soap/php_http.c on line 467
>
> Fixed.
>
> > ext/sqlite/libsqlite/src/encode.c on lines 204, 213 (external code
> > library)
>
> This code cannot be reached.
>
> > readdir: (use readdir_r)
> >
> > ext/pcre/pcrelib/pcregrep.c on line 261
>
> This code cannot be reached.
>
> > main/streams/php_scandir.c on line 74
>
> Fixed.
>
> Ilia Alshanetsky