Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26742
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.82.230 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:in-reply-to:references:mime-version:x-priority:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender;
        b=k9VNQ2Yxn+UG8V3GnjoWzj20Whsw0pxlHiFrI8weerPsHJloRPSGnMGiSE7m7Wi/XWBBV0OnB6LXjsjY933jczB96HvZ44Wlk2hMyKCAYKnna40KFj0GrKugc9D9yIdzsrlOvvTX2UqIGJiVoSAvl3zLtwEodYkPe8H/ZIrxEag=
In-Reply-To: <74.6A.43708.5A94B654@pb1.pair.com>
References: <74.6A.43708.5A94B654@pb1.pair.com>
Mime-Version: 1.0 (Apple Message framework v752.3)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <773C5559-F08C-45EF-BCC1-211C26E93534@prohost.org>
Cc: internals@lists.php.net
Content-Transfer-Encoding: 7bit
Date: Thu, 30 Nov 2006 11:39:01 -0500
To: Ron Korving <r.korving@xit.nl>
Sender: Ilia Alshanetsky <iliaal@gmail.com>
Subject: Re: [PHP-DEV] thread unsafety inventory
From: ilia@prohost.org (Ilia Alshanetsky)


On 27-Nov-06, at 3:24 PM, Ron Korving wrote:
> gmtime: (use gmtime_r)
>
> ext/interbase/ibase_query.c on line 679

Fixed.

> ext/pdo_sqlite/sqlite/src/date.c on line 948 (external code library)

This code cannot be reached since we compile libsqlite with date  
functions.

> sapi/thttpd_patch on lines 282, 1355, 2298

External application patch, can't be helped.

> ctime: (use ctime_r)
>
> ext/mime_magic/mime_magic.c on line 1759

Fixed.

> localtime: (use localtime_r)
>
> ext/com_dotnet/com_variant.c on line 818

Win32 only code and there localtime is already thread-safe.

> ext/pdo_sqlite/sqlite/src/date.c on line 415 (external code library)
> ext/sqlite/libsqlite/src/date.c on line 419 (external code library)
> ext/xmlrpc/libxmlrpc/xmlrpc.c on line 234 (external code library)
> ext/zip/lib/zip_dirent.c on lines 398, 525 (external code library)

Fixed. You may want to report the sqlite issues to sqlite devs so  
that they can apply a fix in their code base as well.

> sapi/thttpd_patch on line 2300 (external code library)

External application patch, can't be helped.

> crypt: (use crypt_r)
>
> ext/standard/crypt.c on line 149

Fixed.

> rand: (use rand_r)
>
> ext/mcrypt/mcrypt.c on line 1042
> ext/soap/php_http.c on line 467

Fixed.

> ext/sqlite/libsqlite/src/encode.c on lines 204, 213 (external code  
> library)

This code cannot be reached.

> readdir: (use readdir_r)
>
> ext/pcre/pcrelib/pcregrep.c on line 261

This code cannot be reached.

> main/streams/php_scandir.c on line 74

Fixed.

Ilia Alshanetsky