Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26688
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 82.135.5.144 cause and error)
To: Kevin Waterson <kevin@oceania.net>
Cc: internals@lists.php.net
In-Reply-To: <20061121093000.2ac91e34.kevin@oceania.net>
References: <20061121055451.02cc12d5.kevin@oceania.net>
	 <45620010.4010504@caedmon.net> <1164061309.2947.899.camel@johannes.nop>
	 <20061121093000.2ac91e34.kevin@oceania.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Tue, 21 Nov 2006 00:54:54 +0100
Message-ID: <1164066894.2947.982.camel@johannes.nop>
Mime-Version: 1.0
Subject: Re: [PHP-DEV] phps line numbering
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Tue, 2006-11-21 at 09:30 +1100, Kevin Waterson wrote:
> This one time, at band camp, Johannes Schl=C3=BCter <johannes@php.net> wr=
ote:
>=20
>=20
> > [^1] If I remember correct the last version of the patch I proposed
> > didn't add just one additional parameter but three of them. The first t=
o
> > enable the line numbering, the second to enable jumpmarks using <a
> > name=3D"" or id=3D"" attributes (I think the latter but am not sure) an=
d a
> > third one to give these jumpmarks individual prefixes to allow posting
> > multiple numbered code snippets on a single page.
>=20
> outstading :)
>=20
> Why not also a parameter to select the beginning line??
> so that you might begin the numbering from lin3 number 322

I don't think this is really needed, the numbering of the <ol> I'm using
there can be changed by CSS and I think it's better to let the user
count the lines used by the jumpmarks than adding yet another parameter,
I even think it might be good to merge my second and third param
(false/null no jump mark, true default, some stirng use that as prefix)
into one (which still doesn't mean there being place for some other)
functions with too many option parameters are just painful imo.

johannes
--=20
Johannes Schl=C3=BCter | http://schlueters.de