Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26686
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 82.135.5.144 cause and error)
To: Sean Coates <sean@caedmon.net>
Cc: Kevin Waterson <kevin@oceania.net>, internals@lists.php.net
In-Reply-To: <45620010.4010504@caedmon.net>
References: <20061121055451.02cc12d5.kevin@oceania.net>
	 <45620010.4010504@caedmon.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Date: Mon, 20 Nov 2006 23:21:49 +0100
Message-ID: <1164061309.2947.899.camel@johannes.nop>
Mime-Version: 1.0
Subject: Re: [PHP-DEV] phps line numbering
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

the approached I used in my initial implementation works with most
browsers fine (IE 6, IE 7, Konqueror) There's just one rarely used
Browser, called Firefox (and it's friends), where it won't work. Firefox
<=3D1.5 adds an # in front of every line when pasting the list's contents
somewhere, Firefox 2 adds the number.

In my opinion this isn't a big problem since in the implementation it
adds only an[^1] optional parameter to the highlight_[strig|file]
functions and is not changing the phps output (which would need an
addition ini setting or maybe one might use the GET parameters to turn
it on...) So it should "harm" only the ones requesting it. When first
proposing it I was told that someone who knows the parser should have a
look at it to avoid problems there, even though the patch shouldn't have
any impact as far as I can see but nobody had the time to look into it.

If there's an serious consideration I can check my disk apply it to the
current CVS and post that patch again.

[^1] If I remember correct the last version of the patch I proposed
didn't add just one additional parameter but three of them. The first to
enable the line numbering, the second to enable jumpmarks using <a
name=3D"" or id=3D"" attributes (I think the latter but am not sure) and a
third one to give these jumpmarks individual prefixes to allow posting
multiple numbered code snippets on a single page.

johannes

On Mon, 2006-11-20 at 14:20 -0500, Sean Coates wrote:
> > Back in March we were discussing the adoption of a patch for 5.2/6 for
> >  line numbering in phps.
> >=20
> > When last discussed, most folks thought the idea was good and it did no=
t
> > impact on anything else dramatically.
>=20
> We determined that there's no reliable way to number lines and maintain
> copy-and-paste.
>=20
> S
>=20
--=20
Johannes Schl=C3=BCter | http://schlueters.de