Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26670 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 41685 invoked by uid 1010); 20 Nov 2006 18:49:08 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 41670 invoked from network); 20 Nov 2006 18:49:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Nov 2006 18:49:08 -0000 Authentication-Results: pb1.pair.com header.from=ceo@l-i-e.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ceo@l-i-e.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain l-i-e.com from 67.139.134.202 cause and error) X-PHP-List-Original-Sender: ceo@l-i-e.com X-Host-Fingerprint: 67.139.134.202 o2.hostbaby.com FreeBSD 4.7-5.2 (or MacOS X 10.2-10.3) (2) Received: from [67.139.134.202] ([67.139.134.202:1861] helo=o2.hostbaby.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/B0-33211-2A8F1654 for ; Mon, 20 Nov 2006 13:49:08 -0500 Received: (qmail 3548 invoked by uid 98); 20 Nov 2006 18:49:06 -0000 Received: from 127.0.0.1 by o2.hostbaby.com (envelope-from , uid 1013) with qmail-scanner-1.25 (clamdscan: 0.88.4/2205. Clear:RC:1(127.0.0.1):. Processed in 1.213296 secs); 20 Nov 2006 18:49:06 -0000 X-Qmail-Scanner-Mail-From: ceo@l-i-e.com via o2.hostbaby.com X-Qmail-Scanner: 1.25 (Clear:RC:1(127.0.0.1):. Processed in 1.213296 secs) Received: from unknown (HELO l-i-e.com) (127.0.0.1) by localhost with SMTP; 20 Nov 2006 18:49:03 -0000 Received: from 208.195.234.246 (SquirrelMail authenticated user ceo@l-i-e.com) by www.l-i-e.com with HTTP; Mon, 20 Nov 2006 12:49:03 -0600 (CST) Message-ID: <41551.208.195.234.246.1164048543.squirrel@www.l-i-e.com> In-Reply-To: References: Date: Mon, 20 Nov 2006 12:49:03 -0600 (CST) To: dsp@php.net Cc: internals@lists.php.net Reply-To: ceo@l-i-e.com User-Agent: Hostbaby Webmail MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Subject: Re: [PHP-DEV] [PATCH] For Bug #38770 From: ceo@l-i-e.com ("Richard Lynch") On Wed, November 15, 2006 4:50 pm, David Soria Parra wrote: > It#s not the best way, the best way might be to cast the signed > integers > to unsigned in the pack command not in the unpack, but that might be a > BC. Assuming it works and does what it's supposed to for 'N' it seems like a fine patch to me... BUT: I would presume that somewhere "out there" in User-land PHP code, somebody is already working around this issue and their "fix" might be messed up by this changing. So, to some degree, this is a BC breaking bugfix. I dunno what policy is in place, but it seems to me that it would be best to only apply this patch in 6.x to avoid problems... This would be mitigated if, like, N is a not-often-used pack mode, and there is already another one that is the obvious work-around for it on 64-bit platforms, or something like that, so that it's super unlikely that there is any user-land code to work-around N in some way that this patch will break. -- Some people have a "gift" link here. Know what I want? I want you to buy a CD from some starving artist. http://cdbaby.com/browse/from/lynch Yeah, I get a buck. So?