Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26647
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <455C9A24.4080705@zend.com>
Date: Thu, 16 Nov 2006 20:04:36 +0300
User-Agent: Thunderbird 1.5.0.7 (X11/20060909)
MIME-Version: 1.0
To: Antony Dovgal <antony@zend.com>
CC: php-dev <internals@lists.php.net>
References: <4558E5E7.5040809@zend.com>
In-Reply-To: <4558E5E7.5040809@zend.com>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] fgets()/fgetss() BC break in HEAD
From: antony@zend.com (Antony Dovgal)


The issue is now solved, thank you.
EOD

On 11/14/2006 12:38 AM, Antony Dovgal wrote:
> Hello all.
> 
> I'd like to continue recent IRC discussion here, to draw more attention to this issue.
> 
> At the moment functions fgets() and fgetss() are broken in HEAD, as they return <maxlen> 
> characters instead of <maxlen - 1>, as they do in 5.2 (and I'm pretty sure this is the way 
> they used to work since their very first appearance in PHP).
> So, anybody relying on fgets($fp, 10) to return 9 characters would get 10 characters instead.
> 
> Yes, this behaviour is not very intuitive for those who are not familiar with fgets() in C, 
> but it's well documented and pretty much expected.
> 
> I believe this is an unreasonable BC break and I strongly believe it should be fixed.
> There are 0 reasons to do it (without any discussion) and it can only result in more users' confusion, 
> even if the original purpose was the contrary.
> 


-- 
Wbr, 
Antony Dovgal