Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26646
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.190 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=UVSCiv9SWjgwR+eDxqOkA8Ue2Usn+lB5vKrQ9Hubp8QyhgL/wpXlp/oYgs7UUSzZWDJVza1rIIdTJiET46s/7CWvw2WDhrKARohz/8AAPlvOsDKbmrfLKXTLPdqpnbZ0YpV0bPu4Vgtsau8mpxYYCfmjKayYxBXdkFJtJ02ut+4=
Message-ID: <4e89b4260611160840p19ad23acg100d9ce44655bd2c@mail.gmail.com>
Date: Thu, 16 Nov 2006 11:40:00 -0500
To: "Mario Wolff" <wolfshoehle@googlemail.com>
Cc: internals@lists.php.net
In-Reply-To: <9bb5e33f0611160752g38cdc4acy92e0f72b9aee9c8b@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <9bb5e33f0611160505u2ac2b1dbt1b04feea4314331c@mail.gmail.com>
	 <4e89b4260611160629o1855ed28pf37139f1576fa99b@mail.gmail.com>
	 <9bb5e33f0611160721l6676cbe5ud0185127fad03402@mail.gmail.com>
	 <9bb5e33f0611160745i4ef015e7i16933d7a4904a6ff@mail.gmail.com>
	 <9bb5e33f0611160752g38cdc4acy92e0f72b9aee9c8b@mail.gmail.com>
Subject: Re: [PHP-DEV] Enable authorizer-feature in PDO_SQLITE
From: kingwez@gmail.com ("Wez Furlong")

I think it would be better to pass in the pdo_dbh_t as the autharg to
the C level callback and then use that to determine if any of the
expensive work needs to be done in the callback.

static int authorizer(....)
{
  pdo_dbh_t *db;

  /* keep the current safemode / basedir checks "cheap" and fast */
  if (existing safe_mode and open_base dir return SQLITE_DENY) {
    return SQLITE_DENY;
  }

 db = (pdo_dbh_t*)autharg;
 if (db->user_authorizer) {
   TSRMLS_FETCH();

   ...

   free stuff
 }
}

You should take a look at how the pdo_sqlite_fci stuff works and adopt
that for the authorizer callback, as it will help improve runtime
performance there.

It would also be best to register constants for the various SQLITE_XXX codes
rather than creating strings and having the PHP code check against strings.
This will also improve performance at runtime.

--Wez.

On 11/16/06, Mario Wolff <wolfshoehle@googlemail.com> wrote:
> Short test script:
>
> <?php
> $data = array( 'one', 'two', 'three', 'four', 'five', 'six');
> $db = new PDO( 'sqlite::memory:');
> echo "register authorizer\n";
> $db->sqliteSetAuthorizer('auth');
> $db->exec( "CREATE TABLE strings( a)");
> $insert = $db->prepare( 'INSERT INTO strings VALUES ( ?)');
> foreach ( $data as $str) {
>
>        $insert->execute( array( $str));
> }
> $insert = null;
> echo "unregister authorizer\n";
> $db->sqliteSetAuthorizer();
>
> function auth($type,$arga,$argb,$argc,$argd ){
>     echo "$type\t$arga\t$argb\t$argc\t$argd\n";
>     return true;
> }
> print_r( $db->query( 'SELECT sqlite_version( *);')->fetchAll( ));
>
> ?>
>
> gives:
> register authorizer
> SQLITE_INSERT   sqlite_master           main
> SQLITE_CREATE_TABLE     strings         main
> SQLITE_UPDATE   sqlite_master   type    main
> SQLITE_UPDATE   sqlite_master   name    main
> SQLITE_UPDATE   sqlite_master   tbl_name        main
> SQLITE_UPDATE   sqlite_master   rootpage        main
> SQLITE_UPDATE   sqlite_master   sql     main
> SQLITE_READ     sqlite_master   ROWID   main
> SQLITE_READ     sqlite_master   name    main
> SQLITE_READ     sqlite_master   rootpage        main
> SQLITE_READ     sqlite_master   sql     main
> SQLITE_READ     sqlite_master   tbl_name        main
> SQLITE_INSERT   strings         main
> unregister authorizer
> Array
> (
>     [0] => Array
>         (
>             [sqlite_version( *)] => 3.3.7
>             [0] => 3.3.7
>         )
>
> )
>