Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26637 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60883 invoked by uid 1010); 15 Nov 2006 22:50:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 60861 invoked from network); 15 Nov 2006 22:50:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Nov 2006 22:50:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=antony@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=antony@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: antony@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:24682] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 87/5E-53553-7C99B554 for ; Wed, 15 Nov 2006 17:50:50 -0500 Received: (qmail 12912 invoked from network); 15 Nov 2006 22:49:17 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 15 Nov 2006 22:49:17 -0000 Message-ID: <455B99C3.6090504@zend.com> Date: Thu, 16 Nov 2006 01:50:43 +0300 User-Agent: Thunderbird 1.5.0.7 (X11/20060909) MIME-Version: 1.0 To: Michael Wallner CC: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] typo in zend_API.h (add_index_ascii_string) From: antony@zend.com (Antony Dovgal) Fixed, thanks. On 11/16/2006 01:41 AM, Michael Wallner wrote: > There, length should be assigned to ___u_len. > > Regards, > > > ------------------------------------------------------------------------ > > Index: Zend/zend_API.h > =================================================================== > RCS file: /repository/ZendEngine2/zend_API.h,v > retrieving revision 1.268 > diff -u -p -d -r1.268 zend_API.h > --- Zend/zend_API.h 27 Oct 2006 21:22:05 -0000 1.268 > +++ Zend/zend_API.h 15 Nov 2006 22:38:21 -0000 > @@ -1252,7 +1252,7 @@ ZEND_API int add_index_zval(zval *arg, u > > #define add_index_ascii_stringl(arg, idx, str, length, flags) do { \ > if (UG(unicode)) { \ > - int ___u_len; \ > + int ___u_len = length; \ > UChar *___u_str = zend_ascii_to_unicode((str), (___u_len)+1 ZEND_FILE_LINE_CC); \ > if ((flags) & ZSTR_AUTOFREE) { \ > efree(str); \ > > -- Wbr, Antony Dovgal