Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26573 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95365 invoked by uid 1010); 14 Nov 2006 18:59:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 95349 invoked from network); 14 Nov 2006 18:59:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Nov 2006 18:59:42 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.173 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 66.249.92.173 ug-out-1314.google.com Linux 2.4/2.6 Received: from [66.249.92.173] ([66.249.92.173:9244] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1F/18-41479-D121A554 for ; Tue, 14 Nov 2006 13:59:42 -0500 Received: by ug-out-1314.google.com with SMTP id 80so1402598ugb for ; Tue, 14 Nov 2006 10:59:38 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=so6DxYW8LSk8f1pL/rdr5VingpsBlGgRtWjILYJpsR5h15tIvMOIEUE0i0iD71sE7aqonNHlrH5c+yabkhsPAcns1cXTSjWdnZL6883IulBXDRFaPxuXSHhn6Mys5Ln0WaXq74vlJAY7JKkmmwuVdOYo2FTi2WOqcDhf1YYiU70= Received: by 10.78.117.10 with SMTP id p10mr1289287huc.1163530778146; Tue, 14 Nov 2006 10:59:38 -0800 (PST) Received: by 10.78.137.6 with HTTP; Tue, 14 Nov 2006 10:59:38 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2006 19:59:38 +0100 To: "Antony Dovgal" Cc: "Stanislav Malyshev" , "Ilia Alshanetsky" , RQuadling@googlemail.com, php-dev In-Reply-To: <455A051A.4090503@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4558E5E7.5040809@zend.com> <10845a340611140024l4902ea09q600a43c5018e819c@mail.gmail.com> <45597FA6.90808@zend.com> <3504EED4-37E2-4EE2-807E-9C3FEB81973F@prohost.org> <455A02B0.9010405@zend.com> <455A051A.4090503@zend.com> Subject: Re: [PHP-DEV] fgets()/fgetss() BC break in HEAD From: pierre.php@gmail.com (Pierre) Hello, On 11/14/06, Antony Dovgal wrote: > On 11/14/2006 08:56 PM, Pierre wrote: > > Hello, > > > > On 11/14/06, Stanislav Malyshev wrote: > >> > The comparison Tony made was between <=5.X and PHP 6, I do not believe > >> > anyone is suggesting to modify the 5.2.x behavior. > >> > >> Yes, I noticed later it's PHP 6, but it does not change a thing - it's > >> still totally unnecessary BC break for the sake of meaningless purism. > >> It adds nothing to the language or functionality and would break a lot > >> of code. It should be fixed to be compatible with previous versions. > > > > I have to agree, it is purely a cosmetic change. "Renaming" the > > argument can make the purists happier. > > > > However, as a counter argument, a quick search in codesearch/koders > > show that very few people rely on this behavior. > > I don't think the number of people relying on this behaviour changes the fact that it's a BC break. Indeed no, but I only said that the affected users can be small. But I don't really worry about this issue, if we cannot break such things in major versions, when can we do it (this one or another)? For the record, I'm in favour of changing the name of the argument and restore the old behavior, problem solved. --Pierre