Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26568 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9304 invoked by uid 1010); 14 Nov 2006 14:31:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 9288 invoked from network); 14 Nov 2006 14:31:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Nov 2006 14:31:49 -0000 Authentication-Results: pb1.pair.com smtp.mail=rquadling@googlemail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=rquadling@googlemail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 64.233.162.193 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: rquadling@googlemail.com X-Host-Fingerprint: 64.233.162.193 nz-out-0102.google.com Linux 2.4/2.6 Received: from [64.233.162.193] ([64.233.162.193:40017] helo=nz-out-0102.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/74-13189-253D9554 for ; Tue, 14 Nov 2006 09:31:48 -0500 Received: by nz-out-0102.google.com with SMTP id q3so545966nzb for ; Tue, 14 Nov 2006 06:31:46 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=googlemail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Tsb/27aUwEEW/pAQUi0EGI9jF6lMGVPVuUafpdftPoyyDadcpgQzX1JYAsAbhQyzeRLqyTZFWOmFewzoeogU21EplN5ZZT9anCxHdHQ+VQQTWXXMTGAKXtXYgdY4eh014/h/JnowkyvSU9sHZhayHDOR5hgr3OdNBW1/SEZwxr0= Received: by 10.35.98.6 with SMTP id a6mr1155876pym.1163514702245; Tue, 14 Nov 2006 06:31:42 -0800 (PST) Received: by 10.35.97.14 with HTTP; Tue, 14 Nov 2006 06:31:41 -0800 (PST) Message-ID: <10845a340611140631t1f779824lc092bcae68f4f034@mail.gmail.com> Date: Tue, 14 Nov 2006 14:31:42 +0000 Reply-To: RQuadling@GoogleMail.com To: "Ilia Alshanetsky" Cc: "Stanislav Malyshev" , "Antony Dovgal" , php-dev In-Reply-To: <3504EED4-37E2-4EE2-807E-9C3FEB81973F@prohost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4558E5E7.5040809@zend.com> <10845a340611140024l4902ea09q600a43c5018e819c@mail.gmail.com> <45597FA6.90808@zend.com> <3504EED4-37E2-4EE2-807E-9C3FEB81973F@prohost.org> Subject: Re: [PHP-DEV] fgets()/fgetss() BC break in HEAD From: rquadling@googlemail.com ("Richard Quadling") On 14/11/06, Ilia Alshanetsky wrote: > > On 14-Nov-06, at 3:34 AM, Stanislav Malyshev wrote: > > >> It seems utterly ridiculous to return maxlen-1. > >> Whilst this is sure as hell a BC, it should work "properly". If I ask > >> for 10, I want 10. I wouldn't have asked for 10 otherwise. Having to > >> know the "magic" to get things to work is plainly bad magic. > > > > It always returned length-1, manual says length-1, so suddenly in > > version 5.2.1 it starts returning length instead. And now imagine > > somebody who tries to use this function in his scripts. He should > > start adding version checks to each invocation of this function or > > what? Doesn't seem very nice behavior to me. > > The comparison Tony made was between <=5.X and PHP 6, I do not > believe anyone is suggesting to modify the 5.2.x behavior. Absolutely. This should be a V6 tidy-up. -- ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulders of some very clever giants!"