Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26566 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7314 invoked by uid 1010); 14 Nov 2006 14:27:57 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7299 invoked from network); 14 Nov 2006 14:27:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Nov 2006 14:27:57 -0000 Authentication-Results: pb1.pair.com smtp.mail=iliaal@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=iliaal@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.162.193 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: iliaal@gmail.com X-Host-Fingerprint: 64.233.162.193 nz-out-0102.google.com Linux 2.4/2.6 Received: from [64.233.162.193] ([64.233.162.193:57982] helo=nz-out-0102.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B7/14-13189-D62D9554 for ; Tue, 14 Nov 2006 09:27:57 -0500 Received: by nz-out-0102.google.com with SMTP id q3so545077nzb for ; Tue, 14 Nov 2006 06:27:55 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=hLFQB3sxhswcdMcMbp0CQeDLRW7AEoWnPc/ZhCzQ1cJwwuCp2u+fVTE25yLyCo2gec9WOQR3tRE5/HclnLklXVOuU2sN95ngTe6P6mIM+rMSGw8uXAbMflWJcQTIqrLpmhti4KNNiYL72OzMPxy6oUDza8jwweL1L1SMN2mzZ+w= Received: by 10.65.185.13 with SMTP id m13mr1277419qbp.1163514475255; Tue, 14 Nov 2006 06:27:55 -0800 (PST) Received: from ?192.168.1.6? ( [74.108.69.82]) by mx.google.com with ESMTP id e15sm8083217qbe.2006.11.14.06.27.54; Tue, 14 Nov 2006 06:27:54 -0800 (PST) In-Reply-To: <45597FA6.90808@zend.com> References: <4558E5E7.5040809@zend.com> <10845a340611140024l4902ea09q600a43c5018e819c@mail.gmail.com> <45597FA6.90808@zend.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: <3504EED4-37E2-4EE2-807E-9C3FEB81973F@prohost.org> Cc: RQuadling@GoogleMail.com, Antony Dovgal , php-dev Content-Transfer-Encoding: 7bit Date: Tue, 14 Nov 2006 09:27:45 -0500 To: Stanislav Malyshev X-Mailer: Apple Mail (2.752.3) Sender: Ilia Alshanetsky Subject: Re: [PHP-DEV] fgets()/fgetss() BC break in HEAD From: ilia@prohost.org (Ilia Alshanetsky) On 14-Nov-06, at 3:34 AM, Stanislav Malyshev wrote: >> It seems utterly ridiculous to return maxlen-1. >> Whilst this is sure as hell a BC, it should work "properly". If I ask >> for 10, I want 10. I wouldn't have asked for 10 otherwise. Having to >> know the "magic" to get things to work is plainly bad magic. > > It always returned length-1, manual says length-1, so suddenly in > version 5.2.1 it starts returning length instead. And now imagine > somebody who tries to use this function in his scripts. He should > start adding version checks to each invocation of this function or > what? Doesn't seem very nice behavior to me. The comparison Tony made was between <=5.X and PHP 6, I do not believe anyone is suggesting to modify the 5.2.x behavior. Ilia Alshanetsky