Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26548 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48140 invoked by uid 1010); 14 Nov 2006 05:26:30 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 48125 invoked from network); 14 Nov 2006 05:26:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Nov 2006 05:26:30 -0000 Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:1160] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 11/4A-60788-38359554 for ; Tue, 14 Nov 2006 00:26:29 -0500 Received: (qmail 24576 invoked from network); 14 Nov 2006 05:24:59 -0000 Received: from localhost (HELO ANDILENOVO) (127.0.0.1) by localhost with SMTP; 14 Nov 2006 05:24:59 -0000 To: "'Antony Dovgal'" , "'php-dev'" Date: Mon, 13 Nov 2006 21:26:23 -0800 Message-ID: <02e401c707ad$6de9bd40$6800a8c0@zend.2k> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4558E5E7.5040809@zend.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2962 Thread-Index: AccHbBhdzryQrLANRVaUP9PGjJRE3QAQULUw Subject: RE: [PHP-DEV] fgets()/fgetss() BC break in HEAD From: andi@zend.com ("Andi Gutmans") References: <4558E5E7.5040809@zend.com> Sounds like something which indeed isn't worth breaking. Was this intentional? > -----Original Message----- > From: Antony Dovgal [mailto:antony@zend.com] > Sent: Monday, November 13, 2006 1:39 PM > To: php-dev > Subject: [PHP-DEV] fgets()/fgetss() BC break in HEAD > > Hello all. > > I'd like to continue recent IRC discussion here, to draw more > attention to this issue. > > At the moment functions fgets() and fgetss() are broken in > HEAD, as they return characters instead of 1>, as they do in 5.2 (and I'm pretty sure this is the way > they used to work since their very first appearance in PHP). > So, anybody relying on fgets($fp, 10) to return 9 characters > would get 10 characters instead. > > Yes, this behaviour is not very intuitive for those who are > not familiar with fgets() in C, but it's well documented and > pretty much expected. > > I believe this is an unreasonable BC break and I strongly > believe it should be fixed. > There are 0 reasons to do it (without any discussion) and it > can only result in more users' confusion, even if the > original purpose was the contrary. > > -- > Wbr, > Antony Dovgal > > -- > PHP Internals - PHP Runtime Development Mailing List To > unsubscribe, visit: http://www.php.net/unsub.php >