Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26544
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <4558E5E7.5040809@zend.com>
Date: Tue, 14 Nov 2006 00:38:47 +0300
User-Agent: Thunderbird 1.5.0.7 (X11/20060909)
MIME-Version: 1.0
To: php-dev <internals@lists.php.net>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: fgets()/fgetss() BC break in HEAD
From: antony@zend.com (Antony Dovgal)

Hello all.

I'd like to continue recent IRC discussion here, to draw more attention to this issue.

At the moment functions fgets() and fgetss() are broken in HEAD, as they return <maxlen> 
characters instead of <maxlen - 1>, as they do in 5.2 (and I'm pretty sure this is the way 
they used to work since their very first appearance in PHP).
So, anybody relying on fgets($fp, 10) to return 9 characters would get 10 characters instead.

Yes, this behaviour is not very intuitive for those who are not familiar with fgets() in C, 
but it's well documented and pretty much expected.

I believe this is an unreasonable BC break and I strongly believe it should be fixed.
There are 0 reasons to do it (without any discussion) and it can only result in more users' confusion, 
even if the original purpose was the contrary.

-- 
Wbr, 
Antony Dovgal