Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26508
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain adaniels.nl from 82.94.235.198 cause and error)
Message-ID: <455523C4.70106@adaniels.nl>
Date: Sat, 11 Nov 2006 02:13:40 +0100
User-Agent: Thunderbird 1.5.0.8 (Windows/20061025)
MIME-Version: 1.0
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: strange php_stream_from_zval requires return_value
From: info@adaniels.nl (Arnold Daniels)

Hi,

I've noticed that building an extension will fail when using macro 
php_stream_from_zval and there is not return_value variable within the 
scope.

/root/php-5.1.6/ext/hello/hello.c: In function `streamit':
/root/php-5.1.6/ext/hello/hello.c:58: error: `return_value' undeclared 
(first use in this function)
/root/php-5.1.6/ext/hello/hello.c:58: error: (Each undeclared identifier 
is reported only once
/root/php-5.1.6/ext/hello/hello.c:58: error: for each function it 
appears in.)

when building

void streamit(zval * zstream TSRMLS_DC)
{
    //zval *return_value;  /* Will work if I uncomment this line */
    php_stream *stream;

    php_stream_from_zval(stream, &zstream);
    php_stream_write(stream, "hello\n", 6);
}

PHP_FUNCTION(hello_stream)
{
    zval *zstream;

    if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", 
&zstream))
        return;

    streamit(zstream TSRMLS_CC);

    RETURN_TRUE;
}

When return_value is added, the function will work without a problem.

I'm not sure whether this is bug or expected behavior and if I should 
use the bug reporting site or just post it here on the list. Anyhow it 
looks strange to me.

Best regards,
Arnold