Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26468
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.142.136.132 cause and error)
Message-ID: <028701c704da$247d1fb0$0201a8c0@pc1>
To: <internals@lists.php.net>, "Andrei Zmievski" <andrei@gravitonic.com>
References: <00f001c7048a$b2967030$0201a8c0@pc1> <434F5AED-4D0B-40EF-9817-A16A2844C5FF@gravitonic.com>
Date: Fri, 10 Nov 2006 09:08:55 -0600
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Unicode chars allowed in numbers?
From: php_lists@realplain.com ("Matt Wilmas")

Hi Andrei,

All right, glad I checked.  I had a few things in mind to optimize
is_numeric_string/unicode, and it's fairly straightforward in _string, but
would just make things slower if u_* functions were needed to do the same in
_unicode, so I was going to rethink it.  Now whatever I come up with can be
easily copied to the _unicode version with just minor changes...


Thanks,
Matt


----- Original Message -----
From: "Andrei Zmievski"
Sent: Friday, November 10, 2006

> > Hi Andrei, et al.,
> >
> > I was just looking at README.UNICODE, regarding interpretation of
> > numbers:
> > "we restrict numbers to consist only of ASCII digits," and "Numeric
> > strings
> > are supposed to adhere to the same rules."  Is it correct to take
> > that to
> > mean only UChar's with values from '0'-'9'/0x30-0x39 (and 'a'-'z'
> > equivalents for bases > 10)?
>
> Correct.
>
> > I ask because in zend_u_strtol(), HANDLE_U_NUMERIC() for array
> > keys, etc.,
> > the u_digit() function is used, which also allows non-ASCII, higher-
> > value
> > digit characters, doesn't it?  But then in is_numeric_unicode(), when
> > checking for hex numbers, the ASCII values '0' and 'x' are used,
> > which is
> > what I'd expect after reading README.UNICODE.
>
> You're correct here again, u_digit() should not be used there.
>
> -Andrei