Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:26426
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
To: "'Matt Wilmas'" <php_lists@realplain.com>,
	<internals@lists.php.net>
Date: Wed, 8 Nov 2006 21:19:35 -0800
Message-ID: <069301c703be$a7121c40$6800a8c0@zend.2k>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AccDuiFAtDoQT5eSQM6WZRe8J86nYgABHu3w
In-Reply-To: <008601c703ba$0a9f4940$0201a8c0@pc1>
Subject: RE: [PHP-DEV] Optimization for ..._MULTIPLY_LONG on more systems
From: andi@zend.com ("Andi Gutmans")
References: <008601c703ba$0a9f4940$0201a8c0@pc1>

Nice patch! Looks good to me... Any other thoughts? 

> -----Original Message-----
> From: Matt Wilmas [mailto:php_lists@realplain.com] 
> Sent: Wednesday, November 08, 2006 8:47 PM
> To: internals@lists.php.net
> Subject: [PHP-DEV] Optimization for ..._MULTIPLY_LONG on more systems
> 
> Hi,
> 
> Here's an additional ZEND_SIGNED_MULTIPLY_LONG() for 
> platforms with 32-bit longs that don't use the assembly 
> version (so all Windows systems at least?).  On my Windows 
> system, mul_function() is 40% faster with this version (no 
> overflow), which makes PHP's * operator 20% faster; with 
> overflow mul_function() is 20% faster (though I don't see any 
> difference with the * operator).  The macro is also used in 
> safe_emalloc()...
> 
> Patch just against 5_2 as the file versions are the only difference.
> 
> 
> Matt
>