Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:26130 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17707 invoked by uid 1010); 20 Oct 2006 14:26:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 17692 invoked from network); 20 Oct 2006 14:26:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Oct 2006 14:26:31 -0000 Authentication-Results: pb1.pair.com smtp.mail=iliaal@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=iliaal@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.184.229 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: iliaal@gmail.com X-Host-Fingerprint: 64.233.184.229 wr-out-0506.google.com Linux 2.4/2.6 Received: from [64.233.184.229] ([64.233.184.229:61113] helo=wr-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2C/06-10091-59CD8354 for ; Fri, 20 Oct 2006 10:26:31 -0400 Received: by wr-out-0506.google.com with SMTP id i4so53209wra for ; Fri, 20 Oct 2006 07:26:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=BcVwwrCZKTTPo7Mpd9e4gERkku4BHWZ/NduNPw+r5eovTKGBTzEpCsmZIoqS6ccHRiH+9UtD5qQce5QgcZNvCaTad4gcKdwUEYz4lYdp08Cr9KPUluyFdPq208smDRhjr1eNuyunLqIyQdGj28PdbCQJnO+Rcw7Vs6SHPoDao0E= Received: by 10.65.188.20 with SMTP id q20mr598018qbp; Fri, 20 Oct 2006 07:19:41 -0700 (PDT) Received: from ?192.168.1.6? ( [74.108.69.82]) by mx.google.com with ESMTP id f18sm638021qba.2006.10.20.07.19.40; Fri, 20 Oct 2006 07:19:40 -0700 (PDT) In-Reply-To: <4e89b4260610200527g35248acbr75d454f5af391526@mail.gmail.com> References: <18.FF.27040.69DE7354@pb1.pair.com> <4e89b4260610200527g35248acbr75d454f5af391526@mail.gmail.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: <06079601-18A8-48EE-8A5A-010594B3A71E@prohost.org> Cc: "Lukas Kahwe Smith" , internals@lists.php.net Content-Transfer-Encoding: 7bit Date: Fri, 20 Oct 2006 10:19:34 -0400 To: Wez Furlong X-Mailer: Apple Mail (2.752.3) Sender: Ilia Alshanetsky Subject: Re: [PHP-DEV] a last plead From: ilia@prohost.org (Ilia Alshanetsky) The check itself is done at compile time, so the CPU loss only happens if you don't use an opcode cache, which means you probably don't care much about the performance anyway :). I definitely think we should keep the warning, but as you can tell from my commit I do agree it should be reduced to E_STRICT. On 20-Oct-06, at 8:27 AM, Wez Furlong wrote: > I agree. Aside from making things difficult, these extra checks are > using up CPU cycles when we don't otherwise care about the "problems" > that are being highlighted. > > I've been out of the loop for a couple of months, so I'm really > surprised that we've gotten all the way into late RC with such a > drastic change. > > +1 for reducing the severity of these things. > +0 for taking the checks out. > > --Wez. > > On 10/19/06, Lukas Kahwe Smith wrote: >> Hi, >> >> I just want to say once again that all hell is going to break >> loose once >> we release 5.2.0 as stable thanks to the various fatal errors we are >> adding for perfectly working code that breaks OO theory. >> >> I am talking about this change: >> http://marc.theaimsgroup.com/?l=php-dev&m=114734977430980&w=2 >> >> As well as the rewriting signatures when inheriting and whatever >> other >> fatal errors we are adding to things that are not actually fatal. >> Please >> for the love of PHP, make these E_STRICT or E_NOTICE. Otherwise we >> will >> have an army of angry users that will dwarf the one we were facing >> with >> PHP 4.4. >> >> Now is the time to fix this before RC6. >> >> regards, >> Lukas >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > Ilia Alshanetsky