Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25996 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32242 invoked by uid 1010); 8 Oct 2006 15:02:23 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 32227 invoked from network); 8 Oct 2006 15:02:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Oct 2006 15:02:22 -0000 Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.184 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 64.233.182.184 nf-out-0910.google.com Linux 2.4/2.6 Received: from [64.233.182.184] ([64.233.182.184:7719] helo=nf-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/6A-53364-DF219254 for ; Sun, 08 Oct 2006 11:02:22 -0400 Received: by nf-out-0910.google.com with SMTP id l24so1636943nfc for ; Sun, 08 Oct 2006 08:02:18 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=CSncZh+V57e/0USb7MnXOiPs5w2ajYgQhUCt0B5XMw2SH+mZ4CjYswPsOcDU9azavnQb73S4F/TfBpUkHx48uKrLQ3gEaLZ1g2GOMWV5RfXhKT7InasIvgBoddO3yP35+SMcn3rXsyj58XuYTszZU69lk+bY2eRGnRZ9MsWK95g= Received: by 10.49.36.6 with SMTP id o6mr8628254nfj; Sun, 08 Oct 2006 08:02:18 -0700 (PDT) Received: by 10.48.212.10 with HTTP; Sun, 8 Oct 2006 08:02:18 -0700 (PDT) Message-ID: <7f3ed2c30610080802l38afeb83g2e06679f50bcf115@mail.gmail.com> Date: Sun, 8 Oct 2006 17:02:18 +0200 To: Pierre Cc: "PHP Internals List" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7f3ed2c30610080716r67bb3d9bl608a54fcc3c0cda6@mail.gmail.com> <7f3ed2c30610080742l542dbbachae638f98cdb882d0@mail.gmail.com> Subject: Re: [PHP-DEV] imagefilter() duplicate "wrong param count" message From: hannes.magnusson@gmail.com ("Hannes Magnusson") On 10/8/06, Pierre wrote: > Hello, > > On 10/8/06, Hannes Magnusson wrote: > > On 10/8/06, Pierre wrote: > > > Hello, > > > > > > On 10/8/06, Hannes Magnusson wrote: > > > > imagefilter() currently throws double "wrong param count" error. > > > > Attached is a patch for HEAD that fixes it. > > > > > > You just asked me on IRC and I told you to post one patch to fix all > > > similar issues at once. Why are you posting this question here again? > > > > Because I've already fixed all the others (I could find). Everyone > > seem to be happy about it. > > > > Since you've been flaming me for every single commit I make into ext > > you are involved with I decided to post the patch here (as per your > > request). > > I did not flame you, I asked you to ask before making large changes, > like the last one you did in zip. But asking for an error message fix > is useless, just commit it, don't waste time to ask half of the world. Now you got me confused. The last change I made in ext/zip was an error message fix. After I made it you complained over not asking you first. Now you say "don't waste time asking"? > > I really don't understand the point to discuss that again and again. > It is so easy to post a mail with one patch and that's it, especially > for such non critical patches. But no, it has to be difficult and > discussed during hours. I thought I was doing it now? -Hannes > > Thanks for your understanding and work. > --Pierre >