Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25991
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.185 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ZGoxdNRv5mavocW6QPGDAD1y30SRN452/oQ5CqU2xkTRg4orewbSzSvyZz0ZTN0hJ/CDrStu+qcAYY+TgKsagqlM2UkJdS3LBrBATuFjJoWJ/cWdx1YDHN8is5kX8t7J/oaoFFs12RMcTau+UOBA5FMnpi5wkh5NuN/QcUKiPYk=
Message-ID: <7f3ed2c30610080637r70ac0a49s1fdc41646ada95d0@mail.gmail.com>
Date: Sun, 8 Oct 2006 15:37:17 +0200
To: "Matt W" <php_lists@realplain.com>
Cc: internals@lists.php.net
In-Reply-To: <012c01c6e0a0$f7cf1250$0201a8c0@pc1>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <012c01c6e0a0$f7cf1250$0201a8c0@pc1>
Subject: Re: [PHP-DEV] [PATCH] Error message cleanup
From: hannes.magnusson@gmail.com ("Hannes Magnusson")

On 9/25/06, Matt W <php_lists@realplain.com> wrote:
> Hi,
>
> Don't know if someone wants to check this out and apply it before 5.2's
> release, or whether you want it at all. ;-)  I just noticed how many of the
> php_error_docref()'s still have a period (".") at the end of the text,
> resulting in "... error message. in <file> on line <line>"  Looks
> better/consistent without a period, and I think that's how you want it now,
> isn't it?
>
> I don't know if my regex search found all occurrences, but I fixed up the
> files I found.  The only changes were removing a trailing period (or a space
> in a few places), and a couple typos I noticed in the ones I changed --
> "interger", "can not" -> "cannot", I think that's about all.  Also updated
> the necessary test files I found, to reflect the changes.  I think (hope)
> everything's OK, but haven't tested it!
>
> There looks to be 209/188 changes in 5.2/6, respectively.  BTW, 5.2's
> ext/soap/tests/bugs/bug31755.phpt must be screwed up (new lines) since the
> diff is deleting every line first...
>
> http://realplain.com/php/error_messages.diff
> http://realplain.com/php/error_messages_5_2.diff
>

Thanks! Patch committed to HEAD. Doubt it'll make it into 5.2.0.

-Hannes