Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25956
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.142.136.132 cause and error)
Message-ID: <003601c6e8d8$6e81fb30$0201a8c0@pc1>
To: <internals@lists.php.net>, "Andrei Zmievski" <andrei@gravitonic.com>
References: <016201c6e0ae$a5011240$0201a8c0@pc1> <00e301c6e85b$4ed2e5b0$0201a8c0@pc1> <754cd73041a5eb071a86d6ae0e84eb9a@gravitonic.com>
Date: Thu, 5 Oct 2006 18:46:08 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Small typo in zend_u_strtol
From: php_lists@realplain.com ("Matt W")

Hi Andrei,

----- Original Message -----
From: "Andrei Zmievski"
Sent: Thursday, October 05, 2006


> Are you sure this is correct? I copied the source from BSD strtol
> implementation.
>
> http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/strtol.c?
> rev=1.19&content-type=text/x-cvsweb-markup

Well, copied but modified for Unicode use... like half the for loop is
changed.  In BSD's case, the value of '0', etc. is subtracted from "c"
variable, so it then has the actual numeric value of the digit.  But PHP's
puts the actual numeric value in "val" from u_digit(). "c" is still too high
by '0' 's value (48?).  Finally, their "acc += c" was changed to "acc +=
val" for that reason.  If PHP's had kept "c" *there*, the problem would've
been discovered fast. :-)

Do you see the problem in the examples I gave?  Numbers between 2147483640
and 2147483647 incorrectly set ERANGE, along with similar negative values.

> -Andrei

Matt

> On Oct 5, 2006, at 1:50 AM, Matt W wrote:
>
> > Hi,
> >
> > Was this missed?  I'm sure you want to fix it. :-)  Maybe should've put
> > "bug" instead of "typo" in the subject...
> >
> > Just also sending to you Andrei since it's Unicode related.
> >
> > Patch was an attachment: http://news.php.net/php.internals/25820