Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25952
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain gravitonic.com from 204.11.219.139 cause and error)
In-Reply-To: <00e301c6e85b$4ed2e5b0$0201a8c0@pc1>
References: <016201c6e0ae$a5011240$0201a8c0@pc1> <00e301c6e85b$4ed2e5b0$0201a8c0@pc1>
Mime-Version: 1.0 (Apple Message framework v624)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <754cd73041a5eb071a86d6ae0e84eb9a@gravitonic.com>
Content-Transfer-Encoding: 7bit
Cc: <internals@lists.php.net>
Date: Thu, 5 Oct 2006 09:28:01 -0700
To: "Matt W" <php_lists@realplain.com>
Subject: Re: [PHP-DEV] [PATCH] Small typo in zend_u_strtol
From: andrei@gravitonic.com (Andrei Zmievski)

Are you sure this is correct? I copied the source from BSD strtol  
implementation.

http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/strtol.c? 
rev=1.19&content-type=text/x-cvsweb-markup

-Andrei

On Oct 5, 2006, at 1:50 AM, Matt W wrote:

> Hi,
>
> Was this missed?  I'm sure you want to fix it. :-)  Maybe should've put
> "bug" instead of "typo" in the subject...
>
> Just also sending to you Andrei since it's Unicode related.
>
> Patch was an attachment: http://news.php.net/php.internals/25820
>
>
> ----- Original Message -----
> From: "Matt W"
> Sent: Monday, September 25, 2006
>
>
>> Hi,
>>
>> Noticed this a couple months ago and never sent this simple thing. :-)
>> ERANGE is being triggered too soon because of the wrong variable,  
>> which
>> causes the following (in Unicode mode, of course) on 32-bit:
>>
>> (int) '2147483640' // int(2147483647)
>> '2147483640' + 0 // float(2147483640)
>>
>> Instead of the expected int(2147483640) in both cases.
>>
>>
>> Matt