Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25942 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60064 invoked by uid 1010); 4 Oct 2006 23:03:36 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 60048 invoked from network); 4 Oct 2006 23:03:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Oct 2006 23:03:36 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=good Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.184 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 64.233.182.184 nf-out-0910.google.com Linux 2.4/2.6 Received: from [64.233.182.184] ([64.233.182.184:21733] helo=nf-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9E/55-19536-5CD34254 for ; Wed, 04 Oct 2006 19:03:34 -0400 Received: by nf-out-0910.google.com with SMTP id l24so638805nfc for ; Wed, 04 Oct 2006 16:03:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=X9IWA35hyVb9vMHkntT1gsZvP3UeoO8xgVFky2fMM0ksLtNqz6RT1tgit8Fh0QNUhEusPr8BUsrtP11un+T91mt7A8Vdjf74vHo/CrE4Ceni8mbULVUut8Q/kpkxfBQkcgUNWfhEgPoKGwEW9EqLtLvwekAIX8moeP5jCE8XH/4= Received: by 10.78.97.7 with SMTP id u7mr667322hub; Wed, 04 Oct 2006 16:03:30 -0700 (PDT) Received: by 10.78.122.5 with HTTP; Wed, 4 Oct 2006 16:03:30 -0700 (PDT) Message-ID: Date: Thu, 5 Oct 2006 01:03:30 +0200 To: "Edin Kadribasic" Cc: "Ilia Alshanetsky" , "PHP Internals" , dmitry@zend.com In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_30034_11503263.1160003010347" References: <5AF9BDFB-3D97-4EFB-9329-1DFE0DBB820A@prohost.org> <4523B718.3070905@emini.dk> Subject: Re: [PHP-DEV] RC5 on Thursday From: pierre.php@gmail.com (Pierre) ------=_Part_30034_11503263.1160003010347 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello, On 10/4/06, Pierre wrote: > Hello, > > On 10/4/06, Edin Kadribasic wrote: > > Hi all, > > > > We need to fix http://bugs.php.net/bug.php?id=38989 before the release. > > Some change has broken path handling on windows recently. > > tsrm_virtual_cwd.c 1.74.2.9.2.3 is the last working version > (http://cvs.php.net/viewvc.cgi/TSRM/tsrm_virtual_cwd.c?revision=1.74.2.9.2.3&view=markup&pathrev=PHP_5_2) > > There is a *lot* of changes, but as far as I can see, IS_ABSOLUTE_PATH > is broken. It is used in expand_filepath, for example: Please find a possible fix as attachment, I did not test it intensivelly but it seems to work. Edin, can you take a look at it? It is actually a wonder that this kind of paths worked before Dmitry's commit :) --Pierre ------=_Part_30034_11503263.1160003010347 Content-Type: text/plain; name=TSRM_IS_ABSOLUTE_PATH_W32.txt; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_eswbtahp Content-Disposition: attachment; filename="TSRM_IS_ABSOLUTE_PATH_W32.txt" UkNTIGZpbGU6IC9yZXBvc2l0b3J5L1RTUk0vdHNybV92aXJ0dWFsX2N3ZC5oLHYNCnJldHJpZXZp bmcgcmV2aXNpb24gMS40OC4yLjUuMi4yDQpkaWZmIC11IC13IC1iIC1yMS40OC4yLjUuMi4yIHRz cm1fdmlydHVhbF9jd2QuaA0KLS0tIHRzcm1fdmlydHVhbF9jd2QuaAk0IE9jdCAyMDA2IDEzOjI0 OjE5IC0wMDAwCTEuNDguMi41LjIuMg0KKysrIHRzcm1fdmlydHVhbF9jd2QuaAk0IE9jdCAyMDA2 IDIyOjQ5OjExIC0wMDAwDQpAQCAtNjksNyArNjksNyBAQA0KICNkZWZpbmUgSVNfVU5DX1BBVEgo cGF0aCwgbGVuKSBcDQogCShsZW4gPj0gMiAmJiBJU19TTEFTSChwYXRoWzBdKSAmJiBJU19TTEFT SChwYXRoWzFdKSkNCiAjZGVmaW5lIElTX0FCU09MVVRFX1BBVEgocGF0aCwgbGVuKSBcDQotCShs ZW4gPj0gMiAmJiAoKGlzYWxwaGEocGF0aFswXSkgJiYgcGF0aFsxXSA9PSAnOicpIHx8IElTX1VO Q19QQVRIKHBhdGgsIGxlbikpKQ0KKwkobGVuID49IDIgJiYgKChpc2FscGhhKHBhdGhbMF0pICYm IHBhdGhbMV0gPT0gJzonKSB8fCBJU19VTkNfUEFUSChwYXRoLCBsZW4pIHx8ICggbGVuPjAgJiYg SVNfU0xBU0gocGF0aFswXSkmJiFJU19VTkNfUEFUSChwYXRoLCBsZW4pICApKSkNCiANCiAjZWxp ZiBkZWZpbmVkKE5FVFdBUkUpDQogI2lmZGVmIEhBVkVfRElSRU5UX0g= ------=_Part_30034_11503263.1160003010347--