Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25819
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 69.179.208.43 cause and error)
Message-ID: <015101c6e0ad$06c537b0$0201a8c0@pc1>
To: <internals@lists.php.net>, <RQuadling@GoogleMail.com>
References: <012c01c6e0a0$f7cf1250$0201a8c0@pc1> <10845a340609250625y252b6c32wdc5c9c3f63e369df@mail.gmail.com>
Date: Mon, 25 Sep 2006 09:15:07 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Error message cleanup
From: php_lists@realplain.com ("Matt W")

Hi Richard,

----- Original Message -----
From: "Richard Quadling"
Sent: Monday, September 25, 2006


> On 25/09/06, Matt W <php_lists@realplain.com> wrote:
> > [...]
> >
> > I don't know if my regex search found all occurrences, but I fixed up
the
> > files I found.  The only changes were removing a trailing period (or a
space
> > in a few places), and a couple typos I noticed in the ones I changed --
> > "interger", "can not" -> "cannot", I think that's about all.  Also
updated
> > the necessary test files I found, to reflect the changes.  I think
(hope)
> > everything's OK, but haven't tested it!
> >
> > [...]
>
> What's your regex? What files do you examine.
>
> I've found some error messages ending in ! and some ending with \n.

Using my editor's (NoteTab) Search in Files tool, I searched all files, but
then just *.c since only they had what I was looking for (AFAIK).  The regex
was php_error_docref\(.+\".+[. ]\" which does match incorrectly in some
places, but I just skip ahead. :-)  I looked at each one, so as to not do
something wrong trying to do a blind "Replace All."  (OT: I just now
realized that I don't think I need to escape the regex's double quotes...?
It works, but I must be too used to writing them only in quoted strings
(PHP...). ;-))

I know some of the messages end with "!" (some "?" also), but I figure they
should stay.  The only place I found a \n (\ and n in the file) is in 6's
main/streams/filter.c.  That's kinda weird, though it would just appear as a
space in the browser with HTML (e.g. should prob be changed too).

There was another typo I wasn't sure about in ext/fbsql/php_fbsql.c:
"FrontBase link is not connected, ty to reconnect" -- is it supposed to be
"trying" or what?


Matt